Storwize multiple management ip not raising exceptions

[Jacob Gregor]

Walt pointed out in a patch, https://review.openstack.org/#/c/288320/, that there are a few points where an exception will not be reported back to the user if something goes wrong with the multiple management ip.

This can occur in the following steps:

1. Both san_ip and storwize_san_secondary_ip is enabled.
2. Either ip can be used to create ssh poo initially, then try to execute ssh command.
3. Fails executing ssh command
4. Try switching to the other ip and attempt to execute ssh command.

We will miss any exceptions raised at this point since this portion of the code is not wrapped in a try/except block.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/294268

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/294268
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=29bc11821b7bbad508bbaa610cc3e4f288e935cb
Submitter: Jenkins
Branch: master

commit 29bc11821b7bbad508bbaa610cc3e4f288e935cb
Author: Jacob Gregor <email address hidden>
Date: Thu Mar 17 14:35:24 2016 -0500

    Storwize: Multiple management IP not raising exceptions

    In the case where both the san_ip and the storwize_san_secondary_ip
    are both enabled and both fail to execute a ssh command, no
    exceptions are raised.

    This patch fixes this issue by creating a helper function to switch
    the IP that _run_ssh is using and moving the code into a try/except
    block.

    Unit tests were also added to make sure all exceptions are covered.

    Closes-Bug: 1558729
    Change-Id: Ic472936046bab3a7c428a05bdcdc97492e52eb38

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.