Internal server error when updating an identity provider

Bug #1558670 reported by Rodrigo Duarte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Rodrigo Duarte
Mitaka
Fix Released
Medium
Rodrigo Duarte

Bug Description

Remote IDs for identity providers can not be reused, so during the creation of an identity provider, keystone returns a 409 Conflict when we try to do so. However, the same problem occurs when updating an identity provider and using a remote ID from another registered identity provider, but the duplicate entry error is not treated and a HTTP 500 is returned.

Error trace: http://paste.openstack.org/show/490946/

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294201

Changed in keystone:
assignee: nobody → Rodrigo Duarte (rodrigodsousa)
status: New → In Progress
Changed in keystone:
milestone: none → newton-1
importance: Undecided → Medium
Changed in keystone:
assignee: Rodrigo Duarte (rodrigodsousa) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Rodrigo Duarte (rodrigodsousa)
tags: added: rc-potential
Brant Knudson (blk-u)
tags: added: mitaka-rc-potential
removed: rc-potential
tags: removed: mitaka-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/294201
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=bfcbb3cd7679dd13d5ededd2f3b765d40e0bca7d
Submitter: Jenkins
Branch: master

commit bfcbb3cd7679dd13d5ededd2f3b765d40e0bca7d
Author: Rodrigo Duarte <email address hidden>
Date: Thu Mar 17 14:28:55 2016 -0300

    Add conflict validation for idp update

    Remote IDs conflicts can happen during an identity provider
    update (similar to what happens during create).

    This patch adds the same conflict handling, so a 500 is not
    returned by keystone.

    Change-Id: I1f093dad0b9427027edf4dc1a9f563e99aedad0c
    Closes-Bug: 1558670

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/312923

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (stable/mitaka)

Reviewed: https://review.openstack.org/312923
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=9f04d7d8611bba611cdea3cb7cbab1af3c16bdc8
Submitter: Jenkins
Branch: stable/mitaka

commit 9f04d7d8611bba611cdea3cb7cbab1af3c16bdc8
Author: Rodrigo Duarte <email address hidden>
Date: Thu Mar 17 14:28:55 2016 -0300

    Add conflict validation for idp update

    Remote IDs conflicts can happen during an identity provider
    update (similar to what happens during create).

    This patch adds the same conflict handling, so a 500 is not
    returned by keystone.

    Change-Id: I1f093dad0b9427027edf4dc1a9f563e99aedad0c
    Closes-Bug: 1558670
    (cherry picked from commit bfcbb3cd7679dd13d5ededd2f3b765d40e0bca7d)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 9.0.1

This issue was fixed in the openstack/keystone 9.0.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystone 10.0.0.0b1

This issue was fixed in the openstack/keystone 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.