Volume Encryption page is unnecessary if volume type doesn't encrypted

Bug #1558056 reported by Kenji Ishii
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Kenji Ishii

Bug Description

At the moment, some page like volume list page, volume type list page, volume detail page and so on have a link to Volume Encryption page even though volume type does not encrypted.
So this page is only displayed "Volume is Unencrypted".
In this case, the link which jump to Volume Encryption page is unnecessary.

Kenji Ishii (ken-ishii)
Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/293407

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Wishlist
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
Revision history for this message
Ying Zuo (yingzuo) wrote :

Kenji, your changes will fix defect 1596078 too and I like your changes better than mine :) Feel free to take over that defect.

Revision history for this message
Ying Zuo (yingzuo) wrote :
Changed in horizon:
milestone: next → newton-3
Changed in horizon:
milestone: newton-3 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/293407
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f464f4b1d3f13fc9a24304d46b688e5147dc2a3c
Submitter: Jenkins
Branch: master

commit f464f4b1d3f13fc9a24304d46b688e5147dc2a3c
Author: Kenji Ishii <email address hidden>
Date: Wed Mar 16 21:33:56 2016 +0900

    Add a condition whether displaying the link jump to Encryption page

    At the moment, the link jump to Volume Encryption page is enable
    even though volume does not encrypted. In this case, this page
    is only displayed "Volume is Unencrypted" and it is not informative.
    Therefore, this patch add a condition whether displaying the link
    jump to Volume Encryption page.

    Change-Id: Ic915dc5f05316991ed6943f66db1d1def54dcbaf
    Closes-bug: #1558056

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.