Fact obtained from puppet is not reflected in Racks location data

[Igor Shishkin]

Hello,

https://inventory.infra.mirantis.net/650

Here's an example of srtext location obtained from puppet which is not reflected in object location.

Please fix.

[Alexander Charykov (acharykov)]

It is reflected on raw page. Facter location shown on main page sets manually.

[Igor Shishkin (teran)]

Anyway it breaks previous behaviour and make us suffering with being forced to set locations manually.
I believe this should be address or replaced with other task.

[Alexander Charykov (acharykov)]

Fact is available in raw list. It is not a bug, it is intensional, that location fact is not automatically updates facter_location on InventoryObject.

[Igor Shishkin (teran)]

@Alexander, the thing is not about raw list, the thing is about location property.
Now we're forced to set up location manually, which is not such a good idea because amount of servers we have.

So please fix the issue or suggest another way how to achieve the same - i.e. get locations set automatically(technically it could be possible to do from DCIM, btw).

[Alexander Charykov (acharykov)]

Fact location should not be reflected in Racks location data, because source of this fact is racks itself.

PXEtool gets those fact from racks and pass it to host.

So it is not a bug. Please create request to set location based on DCIM entry.

[Igor Shishkin (teran)]

Since it's broken functionality it's a bug at the moment so we should keep previous behaviour or switch to use DCIM one, since current functionality is unexpected(means broken).

[Igor Shishkin (teran)]

@Alexander, please always put comments about status changes.

[Alexander Charykov (acharykov)]

@Igor I've already wrote why bug is invalid. Do not change status back.

[Igor Shishkin (teran)]

@Alexander, you have forced us to work with locations manually at moment without any notification or workaround.
It's unacceptable and not possible for new orders while we don't even have bulk actions.
I believe this is broken functionality until the way of using locations feature won't be provided in useful way.

[Alexander Charykov (acharykov)]

@Igor it is not "broken functionality" see my comments #3 and #5. It was working incorrectly, so it was fixed.

If you want bulk actions please create a bug for it.

[Igor Shishkin (teran)]

Alexander, the thing is puppet is the only place knows about location for both of VMs and HWs, so I suppose if you don't want to hardcode that binding let's make it configurable.
But now previous behavior we had when PROD was completed is broken, I'm not talking it was right behavior was racks was accepted with it. So previous and useful behavior broken.

[Alexander Charykov (acharykov)]

Igor, puppet isn't the place where is location is real location of object. In case if someone, set it to incorrect value, host can move to another location or not to any location at all.
Also such behavior reflects on pxetool, which would remove host from location, and add new host to another location.

Such changes requires confirmation from engineer, however it takes too much time, to update location for every because we don't have mass confirm/update changes in racks.

[Igor Shishkin (teran)]

@Alexander, puppet is the only place knows about locations for both of VMs and HW nodes, so it's the best place to retrieve such kind of data automatically.
If we set wrong location it's representation in racks will become our smallest problem, so I don't think it makes sense to use this point.

Setting up the node could be truly treated as such kind of confirmation. So I believe this would be enough.
I'm almost sure we should not hardcode such behaviour but add a way to rely on puppet facts we should.

[Alexander Charykov (acharykov)]

See comments above: facter location is shown in raw, auto update will not be done.

[Igor Shishkin (teran)]

Replaced with: https://bugs.launchpad.net/fuel/+bug/1575196