Remove unused view.numcolumns database field

Bug #1557825 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

Spun off from Bug 1537861.

Prior to Mahara 1.8, the view.numcolumns field indicated how many columns a view had, which was important because that's pretty much all the page layout we had in Mahara 1.7 and earlier.

In Mahara 1.8 we moved to the more complicated "flexible layout" system, where a page can have multiple rows, and each row can have a different number of columns and column widths. With that in place, we stopped using the view.numcolumns field.

However, the field stayed in the database for some reason, possibly just overlooked or possibly for backwards compatibility. While working on Bug 1537861, Robert suggested that we should remove this column, because at the moment it's vestigial and just makes things confusing for people looking at the database and/or the code.

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: none → 16.04.0
importance: Undecided → Low
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5974
Committed: https://git.mahara.org/mahara/mahara/commit/95ffbce0f44de68f4ae8141d27d917af8c3f6a96
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 95ffbce0f44de68f4ae8141d27d917af8c3f6a96
Author: Robert Lyon <email address hidden>
Date: Wed Jan 27 17:12:56 2016 +1300

Bug 1557825: Remove view.numcolumns db column

As this is confusing debugging issues with view layout as the
view.numcolumns column is not actually used anymore for working
out the layout, but it's still being populated when a page is made.

behatnotneeded - existing tests will do

Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.