Server Manager: Fix re-ordering and other code changes which were introduced by re-factoring of puppet

[Thilak Raj]

This bug is to track the code changes for fixing issues which were created by
re-factoring of puppet code.

1.Re-ordering
2.Typo's.
3, Missing notify to service.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18455
Submitter: Thilak Raj (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18455
Committed: http://github.org/Juniper/contrail-puppet/commit/330adaa0f18b0a3662e0820eb0a15fbbc02f9cab
Submitter: Zuul
Branch: R3.0

commit 330adaa0f18b0a3662e0820eb0a15fbbc02f9cab
Author: tsurendra <email address hidden>
Date: Tue Mar 15 14:38:18 2016 -0700

Partial-Bug: #1557755
Server Manager: Fix re-ordering and other code changes which were
introduced by re-factoring of puppet

Issue:
1.database_ip_list was mis-spelt.
2.if database index is not found fail

Change-Id: I0653ee17f4b3fcf6c755352640a5954be370df00

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18633
Submitter: Thilak Raj (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18633
Committed: http://github.org/Juniper/contrail-puppet/commit/1ce1ad4e8278b3668bd6029ab3e67f106859ffef
Submitter: Zuul
Branch: R3.0

commit 1ce1ad4e8278b3668bd6029ab3e67f106859ffef
Author: tsurendra <email address hidden>
Date: Tue Mar 22 11:56:06 2016 -0700

Partial-Bug: #1557755
Server Manager: Fix re-ordering and other code changes which were
introduced by re-factoring of puppet

Issues:
Notify to services was missed while code-re org.

Fix:
Add Notify when package is installed.

Testing:
Provisioned a single node and verified.

Change-Id: I72ca600ca9dfafb88ac77973bdbf1261e2287771

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18697
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18702
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18703
Submitter: Thilak Raj (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18780
Submitter: Thilak Raj (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18697
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18702
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18697
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18780
Committed: http://github.org/Juniper/contrail-puppet/commit/18732286610c76fbb9c181bf76ecf3f1982d7c9a
Submitter: Zuul
Branch: master

commit 18732286610c76fbb9c181bf76ecf3f1982d7c9a
Author: tsurendra <email address hidden>
Date: Tue Mar 15 14:38:18 2016 -0700

Partial-Bug: #1557755
Server Manager: Fix re-ordering and other code changes which were
introduced by re-factoring of puppet

Issue:
1.database_ip_list was mis-spelt.
2.if database index is not found fail

Change-Id: I0653ee17f4b3fcf6c755352640a5954be370df00

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18703
Committed: http://github.org/Juniper/contrail-puppet/commit/3603fec472a4756a4c3d5d5c10456237457438bc
Submitter: Zuul
Branch: master

commit 3603fec472a4756a4c3d5d5c10456237457438bc
Author: tsurendra <email address hidden>
Date: Tue Mar 22 11:56:06 2016 -0700

Partial-Bug: #1557755
Server Manager: Fix re-ordering and other code changes which were
introduced by re-factoring of puppet

Issues:
Notify to services was missed while code-re org.

Fix:
Add Notify when package is installed.

Testing:
Provisioned a single node and verified.

Change-Id: I72ca600ca9dfafb88ac77973bdbf1261e2287771

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18697
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18702
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18697
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18702
Submitter: Abhay Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18702
Committed: http://github.org/Juniper/contrail-puppet/commit/60a39a87bb6c1e184cf8d0c28eaf8f5587785cd8
Submitter: Zuul
Branch: master

commit 60a39a87bb6c1e184cf8d0c28eaf8f5587785cd8
Author: Abhay Joshi <email address hidden>
Date: Tue Mar 29 10:55:03 2016 -0700

Closes-Bug: #1557755
Make changes to puppet modules to have explicit ordering specified for all the resources. With
earlier puppet module clean-up and refactorization changes, there were a few ordering related
bugs/issues were found in the code. This change below, explicitly introduces ordering for even
nested classes with the use of "contain". Also in contrail_all.pp module, now we have removed
use of stages and introduced contain as use of stages is discouraged.

Change-Id: Ibfdc5766dc39e1b5778b5844532fc533d788f92b

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18697
Committed: http://github.org/Juniper/contrail-puppet/commit/77994d382da72128b41a27a95fc240d75afeb4db
Submitter: Zuul
Branch: R3.0

commit 77994d382da72128b41a27a95fc240d75afeb4db
Author: Abhay Joshi <email address hidden>
Date: Wed Mar 23 11:57:06 2016 -0700

Closes-Bug: #1557755
Make changes to puppet modules to have explicit ordering specified for all the resources. With
earlier puppet module clean-up and refactorization changes, there were a few ordering related
bugs/issues were found in the code. This change below, explicitly introduces ordering for even
nested classes with the use of "contain". Also in contrail_all.pp module, now we have removed
use of stages and introduced contain as use of stages is discouraged.

Change-Id: Ibfdc5766dc39e1b5778b5844532fc533d788f92b