OS::Mistral::CronTrigger create fails

[Oleksii Chuprykov]

Create stack with template that contains cron trigger:
  ct:
    type: OS::Mistral::CronTrigger
    properties:
        name: p
        workflow:
            name: abc
        pattern: 0 0 12 * *
        first_time: 2016-4-4 11:11

Get such error:
2016-03-15 16:40:19.903 TRACE heat.engine.resource Traceback (most recent call last):
2016-03-15 16:40:19.903 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 688, in _action_recorder
2016-03-15 16:40:19.903 TRACE heat.engine.resource yield
2016-03-15 16:40:19.903 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 759, in _do_action
2016-03-15 16:40:19.903 TRACE heat.engine.resource yield self.action_handler_task(action, args=handler_args)
2016-03-15 16:40:19.903 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/scheduler.py", line 297, in wrapper
2016-03-15 16:40:19.903 TRACE heat.engine.resource step = next(subtask)
2016-03-15 16:40:19.903 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 730, in action_handler_task
2016-03-15 16:40:19.903 TRACE heat.engine.resource handler_data = handler(*args)
2016-03-15 16:40:19.903 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/openstack/mistral/cron_trigger.py", line 122, in handle_create
2016-03-15 16:40:19.903 TRACE heat.engine.resource cron_trigger = self.client().cron_triggers.create(**args)
2016-03-15 16:40:19.903 TRACE heat.engine.resource TypeError: create() got an unexpected keyword argument 'workflow_name'

After this commit https://github.com/openstack/python-mistralclient/commit/e1f8fe8dc9187a841480e28d21503e5e6d426e96 mistral doesn't receive workflow_name anymore.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/293019

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293019
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f682e7afed80ea0bcd19f42644a64a0b750f3eac
Submitter: Jenkins
Branch: master

commit f682e7afed80ea0bcd19f42644a64a0b750f3eac
Author: Zane Bitter <email address hidden>
Date: Thu Apr 6 15:16:31 2017 -0400

    Fix arguments for OS::Mistral::CronTrigger create

    In python-mistralclient, the `workflow_name` argument was renamed to
    `workflow_identifier` in version 2.0.0, breaking this resource type. Ensure
    that this works with all client versions by passing the first two arguments
    as positional rather than keyword args.

    Change-Id: Ibbed3af468bbc0d68995495095b6cd340c1ea427
    Closes-Bug: #1557575

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/460793

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/460794

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460793
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=54d9e12e5b3880f23bf51c77f968d9352b45f89a
Submitter: Jenkins
Branch: stable/ocata

commit 54d9e12e5b3880f23bf51c77f968d9352b45f89a
Author: Zane Bitter <email address hidden>
Date: Thu Apr 6 15:16:31 2017 -0400

    Fix arguments for OS::Mistral::CronTrigger create

    In python-mistralclient, the `workflow_name` argument was renamed to
    `workflow_identifier` in version 2.0.0, breaking this resource type. Ensure
    that this works with all client versions by passing the first two arguments
    as positional rather than keyword args.

    Change-Id: Ibbed3af468bbc0d68995495095b6cd340c1ea427
    Closes-Bug: #1557575
    (cherry picked from commit f682e7afed80ea0bcd19f42644a64a0b750f3eac)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 8.0.2 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rico Lin (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/460794
Reason: not appear to be that security concern