[fuel-bootstrap] fuel-bootstrap activate ID fails if nailgun password were changed

[Vladimir Khlyunev]

Affected: Fuel 8 Release #570, Fuel 9 - #45

fuel-bootstrap does not allow to pass nailgun password via cli

Steps to reproduce:
1. Deploy Fuel
2. Change nailgun password (fuel user change-password)
3. Rebuild bootstrap or activate new (fuel-bootstrap build --activate)

Result:
The request you have made requires authentication. (HTTP 401) (Request-ID: req-405c7840-a85d-404a-a780-120fe075b03f)

Root cause:
Regardless of activation status the script will notify UI
https://github.com/openstack/fuel-agent/blob/master/contrib/fuel_bootstrap/fuel_bootstrap_cli/fuel_bootstrap/utils/bootstrap_image.py#L270
But at https://github.com/openstack/fuel-agent/blob/master/contrib/fuel_bootstrap/fuel_bootstrap_cli/fuel_bootstrap/objects/master_node_settings.py fuelclient is used as API without passing the credentials into it.
In case of real fail we will get a trace in shell, in case if bootstrap was successfully activated we will get false negative error.

Workaround:
Modify config file mentioned at https://github.com/openstack/python-fuelclient/blob/master/fuelclient/fuelclient_settings.py#L64 and run the command again.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/293350

[Roman Prykhodchenko (romcheg)]

Users are responsible for making any changes to client configuration files.

[Oleg S. Gelbukh (gelbuhos)]

This is not about changes in the client configuration file, it's about incorrect pattern of use of fuelclient in fuel-bootstrap utility. Please, reconsider 'Invalid' status for this bug.

[Arthur Svechnikov (asvechnikov)]

fuel-bootstrap utility has an ability to send notification to WebUI when some errors occurred and Fuel doesn't have active bootstrap image. This notification mechanism should work transparent for user, because it's not related to managing of bootstrap images only improve UX. So I'll set bug to medium in Fuel 9.0 Mitaka and Won't Fix for Fuel 9.0. The solution is: do not raise exception if notification can't be sent.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/293445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293445
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=3af384baeb239439334c543cfcb344c9e37c19f9
Submitter: Jenkins
Branch: master

commit 3af384baeb239439334c543cfcb344c9e37c19f9
Author: Artur Svechnikov <email address hidden>
Date: Wed Mar 16 16:51:50 2016 +0300

    Ignore all exceptions for notifier

    Since notification mechanism is used to improve UX.
    It shouldn't have impact on command processing.
    Otherwise command which was successfully finished
    will have non zero exit code.

    Change-Id: Ib45332ea82b61236805eaf5d2b4012a9863dd044
    Closes-Bug: #1557563

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/293350
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=5ab00f5a88c2b6b555c01f8d9280ed42c257cd69
Submitter: Jenkins
Branch: master

commit 5ab00f5a88c2b6b555c01f8d9280ed42c257cd69
Author: Sergey Abramov <email address hidden>
Date: Wed Mar 16 13:06:27 2016 +0300

    Send credentials as environment variables to subprocess

    send credenetials to fuel-client subprocess as env keyword args.

    Change-Id: I4ab0bb75b939851f19de9b8069bd98cc42164d08
    Related-bug: 1557563

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/294896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/294896
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=38e20cd5b861e654b9c97125a00d36794d9acf4b
Submitter: Jenkins
Branch: stable/8.0

commit 38e20cd5b861e654b9c97125a00d36794d9acf4b
Author: Sergey Abramov <email address hidden>
Date: Wed Mar 16 13:06:27 2016 +0300

    Send credentials as environment variables to subprocess

    send credenetials to fuel-client subprocess as env keyword args.

    Change-Id: I4ab0bb75b939851f19de9b8069bd98cc42164d08
    Related-bug: 1557563
    (cherry picked from commit 5ab00f5a88c2b6b555c01f8d9280ed42c257cd69)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/7.0
Review: https://review.openstack.org/294909

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/294909
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=aa2f4ac35d53a051fab0851b058b83c8516761e8
Submitter: Jenkins
Branch: stable/7.0

commit aa2f4ac35d53a051fab0851b058b83c8516761e8
Author: Sergey Abramov <email address hidden>
Date: Wed Mar 16 13:06:27 2016 +0300

    Send credentials as environment variables to subprocess

    send credenetials to fuel-client subprocess as env keyword args.

    Change-Id: I4ab0bb75b939851f19de9b8069bd98cc42164d08
    Related-bug: 1557563
    (cherry picked from commit 5ab00f5a88c2b6b555c01f8d9280ed42c257cd69)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/295029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295029
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=a53f468c78f9f194df9bfdb5b8aeff96e7b50117
Submitter: Jenkins
Branch: stable/7.0

commit a53f468c78f9f194df9bfdb5b8aeff96e7b50117
Author: Oleg Gelbukh <email address hidden>
Date: Sun Mar 20 20:36:16 2016 +0300

    Use KEYSTONE_* env vars in 7.0

    In 7.0, KEYSTONE_PASS and KEYSTONE_USER environment variables were
    used to pass auth parameters to fuel client. In 8.0, they are
    deprecated and replaced with OS_PASSWORD and OS_USERNAME.

    Replace OS_* vars with KEYSTONE_* vars in 7.0 version only.

    Change-Id: I51f8bbd01ffec1befcb30eeeccd6ad3bd85517ae
    Closes-bug: 1557563

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/295188

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295188
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=ec7c2ca2f9be261ab0c871e3105b06641ac8f22f
Submitter: Jenkins
Branch: master

commit ec7c2ca2f9be261ab0c871e3105b06641ac8f22f
Author: Oleg Gelbukh <email address hidden>
Date: Sun Mar 20 20:36:16 2016 +0300

    Use KEYSTONE_* env vars

    Fix bug with wrong environment variables.
    Replace OS_PASSWORD and OS_USERNAME to KEYSTONE_PASS and KEYSTONE_USER

    Change-Id: I51f8bbd01ffec1befcb30eeeccd6ad3bd85517ae
    Closes-bug: 1557563
    (cherry picked from commit a53f468c78f9f194df9bfdb5b8aeff96e7b50117)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/295250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/295250
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=58a8c150ea0b554cf5308285cb2fb7e7ceab580e
Submitter: Jenkins
Branch: stable/8.0

commit 58a8c150ea0b554cf5308285cb2fb7e7ceab580e
Author: Oleg Gelbukh <email address hidden>
Date: Sun Mar 20 20:36:16 2016 +0300

    Use KEYSTONE_* env vars

    Fix bug with wrong environment variables.
    Replace OS_PASSWORD and OS_USERNAME to KEYSTONE_PASS and KEYSTONE_USER

    Change-Id: I51f8bbd01ffec1befcb30eeeccd6ad3bd85517ae
    Closes-bug: 1557563
    (cherry picked from commit ec7c2ca2f9be261ab0c871e3105b06641ac8f22f)