pecan: nova notifier breaks on errors

Bug #1557516 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

The nova notifier code always assumes there is a previous resource on a PUT action. However, this is not the case in scenarios where an update is attempted on an object that doesn't exist (in which case a 404 will be raised). The current nova code was breaking the 404 by failing in the notification code.

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
importance: Undecided → High
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292872

Changed in neutron:
status: New → In Progress
Changed in neutron:
milestone: mitaka-1 → newton-1
summary: - pecan: nova notifier broke router interface actions
+ pecan: nova notifier broke router interface action errors
summary: - pecan: nova notifier broke router interface action errors
+ pecan: nova notifier breaks on errors
description: updated
Changed in neutron:
assignee: Kevin Benton (kevinbenton) → Brandon Logan (brandon-logan)
Changed in neutron:
assignee: Brandon Logan (brandon-logan) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/292872
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=19348ecd6eefdab5e7ba6cabbeff1d3e124bb00f
Submitter: Jenkins
Branch: master

commit 19348ecd6eefdab5e7ba6cabbeff1d3e124bb00f
Author: Kevin Benton <email address hidden>
Date: Mon Mar 14 07:43:50 2016 -0700

    Pecan: skip all notifications on failures

    If there was a bad status code, none of the notification
    logic should attempt to process. A bad status code means
    that the assumptions the notification code makes about
    original resources being present may not be true.

    This also fixes the exception translator so the correct
    status code is set by the hook on exceptions that have
    a fault map entry.

    Closes-Bug: #1557516
    Change-Id: Ibff419e7caa6de422f04eb1e43fd2aed304bdd97

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

tags: added: neutron-proactive-backport-potential
Changed in neutron:
importance: High → Low
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.