Errors during initial indexing should cause fatal error
Bug #1557003 reported by
Steve McLellan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Searchlight |
Fix Released
|
High
|
Rick Aulino |
Bug Description
If a plugin fails to index correctly, the error is essentially ignored and manage.py moves onto the next one. I can't remember if this was a conscious design decision but it seems like the wrong one, especially once zero-downtime reindexing is implemented. A failure should cause the listener alias to get reset to the old index, the new index be left alone for debugging (along with a message indicating that it exists) and the old index be left.
In a setup with multiple indices any successful indexing operations should then be left alone; a message can indicate to the user what failed and that it's not necessary to reindex the successful indices.
Changed in searchlight: | |
milestone: | none → mitaka-rc1 |
importance: | Undecided → High |
Changed in searchlight: | |
assignee: | nobody → Rick Aulino (rick-aulino) |
Changed in searchlight: | |
status: | New → In Progress |
Changed in searchlight: | |
milestone: | mitaka-rc1 → mitaka-rc2 |
To post a comment you must log in.
This is actually particularly difficult. I do agree we should stop, but my primary concern is that the zero downtime indexing code is just going to leave around a bunch of bad indexes and the listeners will keep populating bad indexes. Soon we'll have dozens of indexes that aren't removed.