python-novaclient does not report a warning when a volume cannot be hotplugged to an instance

[Anatolii Neliubin]

Detailed bug description:
In a situation when a VM instance does not have a virtio driver installed cinder volumes are attached as IDE disks. Since IDE disks cannot be hotplugged these cinder volumes stay unattached; however "nova volume-attach" command does not report that the volume cannot be attached. A message about this error is only reported into /var/log/nova-all.log file:
root@node-4:~# grep TRACE /var/log/nova-all.log|tail
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/dist-packages/eventlet/tpool.py", line 141, in proxy_call
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher rv = execute(f, *args, **kwargs)
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/dist-packages/eventlet/tpool.py", line 122, in execute
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher six.reraise(c, e, tb)
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/dist-packages/eventlet/tpool.py", line 80, in tworker
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher rv = meth(*args, **kwargs)
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher File "/usr/lib/python2.7/dist-packages/libvirt.py", line 524, in attachDeviceFlags
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher if ret == -1: raise libvirtError ('virDomainAttachDeviceFlags() failed', dom=self)
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher libvirtError: Operation not supported: disk bus 'ide' cannot be hotplugged.
2016-03-14 07:18:39.544 10193 TRACE oslo_messaging.rpc.dispatcher
root@node-4:~#
Steps to reproduce:
root@node-1:~# glance image-create --name RouterOS --copy-from http://download2.mikrotik.com/routeros/6.34.3/mikrotik-6.34.3.iso --disk-format iso --container-format bare
root@node-1:~# nova boot --image RouterOS --flavor m1.tiny --nic net-id=55fb58a3-9c69-40d0-aa18-7d95a94f0285 testvm
<output skipped>
root@node-1:~# cinder create --display-name test_volume 1
<output skipped>
root@node-1:~# nova volume-attach 6b85d91c-45fe-4899-a329-d65c00ffba9a 33d6e5bf-5a5d-452d-aeb8-125e1ae42e9f
+----------+--------------------------------------+
| Property | Value |
+----------+--------------------------------------+
| device | /dev/hdb |
| id | 33d6e5bf-5a5d-452d-aeb8-125e1ae42e9f |
| serverId | 6b85d91c-45fe-4899-a329-d65c00ffba9a |
| volumeId | 33d6e5bf-5a5d-452d-aeb8-125e1ae42e9f |
+----------+--------------------------------------+
root@node-1:~# cinder show 33d6e5bf-5a5d-452d-aeb8-125e1ae42e9f
+---------------------------------------+--------------------------------------+
| Property | Value |
+---------------------------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| created_at | 2016-03-14T07:07:21.000000 |
| display_description | None |
| display_name | test_volume |
| encrypted | False |
| id | 33d6e5bf-5a5d-452d-aeb8-125e1ae42e9f |
| metadata | {} |
| multiattach | false |
| os-vol-host-attr:host | rbd:volumes#DEFAULT |
| os-vol-mig-status-attr:migstat | None |
| os-vol-mig-status-attr:name_id | None |
| os-vol-tenant-attr:tenant_id | 0bdfbd845a8a4f3d8d9a259cf8d74e25 |
| os-volume-replication:driver_data | None |
| os-volume-replication:extended_status | None |
| size | 1 |
| snapshot_id | None |
| source_volid | None |
| status | available |
| volume_type | None |
+---------------------------------------+--------------------------------------+
 Expected results:
"nova volume-attach" command should report that a volume cannot be hot-plugged
Workaround:
Install a virtio driver into VM images and attach volumes using virtio driver.
Description of the environment:
- Operation system: Description: Ubuntu 14.04.3 LTS
- Versions of components: MOS 7.0

[Alexander Bozhenko (alexbozhenko)]

Related bugs:
https://bugs.launchpad.net/nova/+bug/1231874
https://bugs.launchpad.net/nova/+bug/1379212

[Roman Podoliaka (rpodolyaka)]

This is a feature request, which should be implemented in upstream first. Thus, moving to 10.0.