WebView.TouchSelectionController needs a 'handleDragInProgress' property
Bug #1556762 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Olivier Tilloy | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
Typically, when a touch selection is active, a quick menu with selectall/
Per design request, we need to temporarily hide that menu while a handle drag is in progress to resize the selection. We need the touch selection controller to expose an additional property for that.
Related branches
lp:~osomon/oxide/touch-selection-api-updates
- Chris Coulson: Approve
-
Diff: 667 lines (+142/-59)20 files modifiedqt/core/browser/oxide_qt_contents_view.cc (+8/-2)
qt/core/browser/oxide_qt_contents_view.h (+3/-1)
qt/core/glue/oxide_qt_contents_view_proxy.h (+2/-0)
qt/core/glue/oxide_qt_contents_view_proxy_client.h (+3/-1)
qt/core/glue/oxide_qt_web_view_proxy.h (+0/-1)
qt/qmlplugin/oxide.qmltypes (+8/-2)
qt/qmlplugin/oxide_qml_plugin.cc (+6/-1)
qt/quick/api/oxideqquicktouchselectioncontroller.cc (+26/-4)
qt/quick/api/oxideqquicktouchselectioncontroller.h (+11/-2)
qt/quick/api/oxideqquickwebview.cc (+2/-8)
qt/quick/api/oxideqquickwebview_p.h (+0/-3)
qt/quick/oxide_qquick_contents_view.cc (+18/-3)
qt/quick/oxide_qquick_contents_view.h (+11/-7)
shared/browser/oxide_render_widget_host_view.cc (+16/-3)
shared/browser/oxide_render_widget_host_view.h (+1/-0)
shared/browser/oxide_render_widget_host_view_container.h (+1/-1)
shared/browser/oxide_web_contents_view.cc (+19/-17)
shared/browser/oxide_web_contents_view.h (+3/-1)
shared/browser/oxide_web_contents_view_client.cc (+2/-1)
shared/browser/oxide_web_contents_view_client.h (+2/-1)
lp:~osomon/webbrowser-app/touch-selection-api-updates-oxide-1.15
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 127 lines (+38/-13)3 files modifieddebian/control (+1/-1)
src/Ubuntu/Web/UbuntuWebView02.qml (+22/-4)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+15/-8)
lp:~osomon/webbrowser-app/use-oxide-1.15-apis
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 295 lines (+126/-21)6 files modifieddebian/control (+2/-2)
src/Ubuntu/Web/UbuntuWebView02.qml (+22/-4)
src/Ubuntu/Web/UserAgent02.qml (+2/-5)
src/app/webbrowser/Browser.qml (+36/-1)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+49/-1)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+15/-8)
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Changed in oxide: | |
| status: | In Progress → Fix Released |
| milestone: | none → branch-1.15 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| milestone: | none → ubuntu-16.10 |
To post a comment you must log in.
