Inherit file's permissions in apache puppet module

[slava valyavskiy]

Optimization with file's permissions in apache module was reverted in following review:
https://review.openstack.org/#/c/269877/4/deployment/puppet/osnailyfacter/manifests/apache.pp

As we have https://github.com/SlavaValAl/puppetlabs-apache/commit/2c54785de4f76ed431eaa2d1060458408f62f6b3 pull request merged it's time to return this optimization back.

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 1.6.0-mos
Change author: slava valyavskiy <email address hidden>
Review: https://review.fuel-infra.org/17987

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/17987
Submitter: Denis Egorenko <email address hidden>
Branch: 1.6.0-mos

Commit: 7eb7b540ce35e374bbe28d8a454590eff5ae863e
Author: slava valyavskiy <email address hidden>
Date: Fri Mar 11 14:32:16 2016

Specify owning permissions for logroot directory

The main goal of this patch is to prevent inheritance of owning
permissions for File resource. For example, if we define somewhere in
high level manifest 'owner' and 'group' values, it will be passed to
apache module and wrong owning permissions will be set. It's critical
for 'logroot' folder as we have '0750' permissions for this folder in
apache package by default.

Change-Id: I4051fd350b7114bb915f07ca4bed55e2fb87920d
Related-bug: #1556084

[Bogdan Dobrelya (bogdando)]

This bug is medium. The fix being reverted was made it to the 8.0 release and it is high. What plans for reverting it for the 8.0 and can we? I believe we should not.

[slava valyavskiy (slava-val-al)]

Hello, Bogdan,

I'm not going to port fix into 8.0 branch, but, what is problem to cover this tech-debt in 9.0 release? Fix from upstream is already ported into our fuel-infra project[0] (1.6.0-rc1 tag). What kind of risk do you see there?

[0] https://github.com/fuel-infra/puppetlabs-apache/commit/7eb7b540ce35e374bbe28d8a454590eff5ae863e

[Bogdan Dobrelya (bogdando)]

My comment was related to the https://review.openstack.org/#/c/291743/
We should not revert a patch, which has backports, only in the master branch. Also, medium bug should not address the revert of a high bug fix

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/293485

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291743
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=379fa1a1175d9929bec59f10339be2969302d4a1
Submitter: Jenkins
Branch: master

commit 379fa1a1175d9929bec59f10339be2969302d4a1
Author: Valyavskiy Viacheslav <email address hidden>
Date: Fri Mar 11 14:33:47 2016 +0000

    Revert 'Do not inherit File owning permissions for apache module'

    This reverts commit 8d62e08d6102893282e8f0dc3e860c0587cc508e.

    Closes-bug: #1556084
    Change-Id: I20ed986f5b5ed190750ff3894dec97d62a0700cf

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 8.0-updates because of Medium importance

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/293485
Reason: Bug was marked "won't fixed" by maintenance team.

[Alisa Tselovalnikova (atselovalnikova)]

Verified on fuel-9.0-mos-516-2016-06-22.