Cooldown period can be activated without scaling activity

Bug #1555748 reported by Omar Soriano
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Rabi Mishra

Bug Description

The cooldown behavior has changed after this commit:
https://github.com/openstack/heat/commit/50cc71e33c40a9e3be604b16f77d3c3cf030a63b

Previously, if there was no change in the size of an autoscaling group, the cooldown period would not be activated. This seems to be the desired behavior, since we don't want a cooldown period when, say, a cpu_util low alarm kicks in and the minimum autoscaling size has already been reached.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291347

Changed in heat:
assignee: nobody → Omar Soriano (omars1515)
status: New → In Progress
Rabi Mishra (rabi)
Changed in heat:
importance: Undecided → High
milestone: none → mitaka-rc1
Rabi Mishra (rabi)
Changed in heat:
importance: High → Medium
Changed in heat:
milestone: mitaka-rc1 → mitaka-rc2
Changed in heat:
milestone: mitaka-rc2 → newton-1
tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/294023

Changed in heat:
assignee: Omar Soriano (omars1515) → Rabi Mishra (rabi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/294945

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/294946

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/291347
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6c25e8302db02203fcb933e5b104507c83b6672c
Submitter: Jenkins
Branch: master

commit 6c25e8302db02203fcb933e5b104507c83b6672c
Author: Omar Soriano <email address hidden>
Date: Thu Mar 10 09:44:57 2016 -0800

    Avoid cooldown when group size does not change

    Cooldown behavior changed in commit:
    50cc71e33c40a9e3be604b16f77d3c3cf030a63b

    Restore the cooldown behavior so that when a group does not encounter
    scaling activity, a cooldown period is not activated.

    Closes-Bug: #1555748
    Change-Id: Icf5df6a48afb9f56aa1c3f1622d33b9998aca39c

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/298153

Changed in heat:
milestone: newton-1 → mitaka-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/298582

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/mitaka)

Reviewed: https://review.openstack.org/298153
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ab8e7a2113c44e5a20d3db58b1aa8a4dd139df68
Submitter: Jenkins
Branch: stable/mitaka

commit ab8e7a2113c44e5a20d3db58b1aa8a4dd139df68
Author: Omar Soriano <email address hidden>
Date: Thu Mar 10 09:44:57 2016 -0800

    Avoid cooldown when group size does not change

    Cooldown behavior changed in commit:
    50cc71e33c40a9e3be604b16f77d3c3cf030a63b

    Restore the cooldown behavior so that when a group does not encounter
    scaling activity, a cooldown period is not activated.

    Closes-Bug: #1555748
    Change-Id: Icf5df6a48afb9f56aa1c3f1622d33b9998aca39c
    (cherry picked from commit 6c25e8302db02203fcb933e5b104507c83b6672c)

tags: added: in-stable-mitaka
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0rc2

This issue was fixed in the openstack/heat 6.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/298582
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=917f10cb3f664962178c818b745f9f0899566557
Submitter: Jenkins
Branch: stable/liberty

commit 917f10cb3f664962178c818b745f9f0899566557
Author: Omar Soriano <email address hidden>
Date: Thu Mar 10 09:44:57 2016 -0800

    Avoid cooldown when group size does not change

    Cooldown behavior changed in commit:
    50cc71e33c40a9e3be604b16f77d3c3cf030a63b

    Restore the cooldown behavior so that when a group does not encounter
    scaling activity, a cooldown period is not activated.

    Closes-Bug: #1555748
    Change-Id: Icf5df6a48afb9f56aa1c3f1622d33b9998aca39c
    (cherry picked from commit 6c25e8302db02203fcb933e5b104507c83b6672c)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302565

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)
Download full text (13.0 KiB)

Reviewed: https://review.openstack.org/302565
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=eeed79b7a2da4a8f7fcbe0c8a7c7a069f304ae11
Submitter: Jenkins
Branch: master

commit bea576f802f993204aaaaea82812820f2f51c668
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Mar 30 16:09:29 2016 +0300

    Sync integration tests requirements

    The patch that auto-generates integration tests requirements [1] missed
    Mitaka release.

    This patch manually syncs the integration tests requirements hopefully
    for the last time.

    [1] Ie79338cc10cc101fbf15b51c7923e3a7b8e4fbb4

    Change-Id: I3f001bcb7900f6d822055bf3567773b3a594227d

commit 950505d956e99bc9eed7d6fb0223800251d88b95
Author: Rabi Mishra <email address hidden>
Date: Wed Mar 30 09:34:36 2016 +0530

    Revert "Check RBAC policy for nested stacks"

    This is causing issues with tripleo failures
    with ValueError, when trying do stack-preview as
    part of policy enforcement for stack DELETE.

    This reverts commit a8accbba98b5fc15562864030f49d20570bf8412.

    Change-Id: I366316f27f24c650bd435e67dd17abd8676cedf4
    Closes-Bug: #1561172
    (cherry picked from commit 354f1bcef038340d95f7dc4bc29268c9efed642e)

commit 184b09a40672ccfe1964bbf4fc72234d4cd012b6
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Mar 30 06:08:07 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I656cedd8162b5a7d1682a33ab9b836ba25d22de9

commit 0c407b8596499466b93d5b511e19b0de130b6f03
Author: Zane Bitter <email address hidden>
Date: Mon Mar 28 17:19:47 2016 -0400

    Add translation rule to delete ssh auth key from Magnum baymodel

    Add a translation rule to ensure that users with existing templates will
    not have them break when they update due to the 'ssh_authorized_key'
    property having been removed from Magnum and hidden in Heat.

    Change-Id: Id73bace93bfc2379e80777da7dc0c0bb059d6cd3
    Related-Bug: #1560284
    (cherry picked from commit 0ab68f891348eeafa1efa219070ef39f776cb6c6)

commit db06ee4514b0cc8037f037788c34631c272cfc6b
Author: Sergey Kraynev <email address hidden>
Date: Thu Mar 24 04:30:39 2016 -0400

    Increase timeout of WaitCondition due to ConcurrentTransactions

    Currently we have retry logic with random period of delay.
    There is a chance, when we have several re-try attemts with maximum
    timeout, so it can be a root cause of floating fails, when we have not
    enough time for getting all signals.

    Also decrease number of signals from 30 to 25, due to small risk, when
    one of signals goes to ConcurrentTransaction error.

    Note, that all these changes are made in corresponding functional test
    and don't affect main code.

    Change-Id: I9ca85c4378d0f62e316f4f40ff73597ffaaabadf
    Related-Bug: #1497274
    (cherry picked from commit 8f370d6174c7574c6ee611b5089eac8a4c37dbf2)

commit 145be139cc8a34c57f84e1991031cfc2595477ba
Author: OpenStack Proposal Bot <openstack-infra...

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/294945
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=480271d89604d4cb09df2735d9115531e14331af
Submitter: Jenkins
Branch: master

commit 480271d89604d4cb09df2735d9115531e14331af
Author: Rabi Mishra <email address hidden>
Date: Sat Mar 19 19:55:55 2016 +0530

    Don't try scaling when no change in size

    Don't resize and send notifications when there is no
    change in size i.e. max/min has been reached.

    This also refactors some exception handling logic.

    Change-Id: I1bb226b3067178dbdab2947609c53f3434aff9fe
    Related-Bug: #1555748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/294946
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2f46d240b5d5d2589f32d46859621bb5e18847de
Submitter: Jenkins
Branch: master

commit 2f46d240b5d5d2589f32d46859621bb5e18847de
Author: Rabi Mishra <email address hidden>
Date: Sat Mar 19 20:12:38 2016 +0530

    Don't scale when action is not complete

    Don't allow scaling when status in not COMPLETE.

    Change-Id: I25323a6d02e00c9efebf112f7c3c47207c1331a3
    Related-Bug: #1555748

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b1

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 5.0.2

This issue was fixed in the openstack/heat 5.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Rabi Mishra (<email address hidden>) on branch: master
Review: https://review.openstack.org/294023
Reason: I actually wanted this change to go in.
I can't do more than 22 patchsets;) Abandoning it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/294023
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0558b10c48734e94b65b35a4d9ad9356ada9f193
Submitter: Zuul
Branch: master

commit 0558b10c48734e94b65b35a4d9ad9356ada9f193
Author: rabi <email address hidden>
Date: Tue Apr 25 13:32:05 2017 +0530

    Remove use of CooldownMixin with scaling policy

    Removes the multiple use of the mixin, so that we don't
    set metadata for both policy and group. Setting the cooldown
    metadata only for group would suffice.

    Change-Id: I241a32b52e0708264c80c3eca313a97534927415
    Related-Bug: #1555748

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.