VMAX: _create_initiator_Group uses multiple CIM calls where one sufices

[Carl Pecinovsky]

emc_vmax_provisioning --> _create_initiator_Group() uses an approach to creating the initiator group that first creates the group and then adds in the HW Resources (WWPNs) one-by-one. First, this is a performance concern because there could be a significant number of initiators. And SMI-S Provider supports passing all the HW Resorce Names on the create call.
Second, we've seen failures in the calls where the wwpns are added to the IG, whereas switching to the single call approach, we could not reproduce the failures.

This was discussed with Helen some time back there was consensus that this change makes sense to do. It is not critical for Mitaka, though.

[Xing Yang (xing-yang)]

Is this change still needed?

[Carl Pecinovsky (csky)]

Xing, I think it is a relatively straightforward change that would benefit the VMAX driver in the ways described earlier. It does not currently gate anything, however.

[Helen Walsh (walshh2)]

Agreed, we will get this submitted soon as it is a simple change. Not guaranteed it will make the Newton cut off but it will be in Ocata

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/369473

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/369473
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f963173a56eb599cb5c67983952c57164f5da960
Submitter: Jenkins
Branch: master

commit f963173a56eb599cb5c67983952c57164f5da960
Author: Helen Walsh <email address hidden>
Date: Tue Sep 13 14:49:10 2016 +0100

    VMAX driver - Create initiator group in single call

    The VMAX driver created the initiator group first
    and then added in the initiators one-by-one. This
    potentially had a performance impact because there could
    be a significant number of initiators. This fix creates
    the initiator group, containing all the initiators, in a
    single call.

    Change-Id: Ib8a2ad067442d6eef06de6888e8787af8e5bd1fc
    Closes-Bug: #1555728

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.