Excess update tags

[Darja Shakhray]

Steps to reproduce on devstack (glance v2):
1) Create image
2) Add tags
3) Update any property (glance image-update)

Expected result:
Sending PATCH request with replace property

Actual result:
Sending PATCH request with replace property and replace all tags

For example:
1) I have image http://paste.openstack.org/show/490002/
2) glance image-update 471079b7-8a19-4fad-97ab-59c196a59234 --name name2
3) sending data '[{"path": "/name", "value": "name2", "op": "replace"}, {"path": "/tags", "value": ["tag1", "tag2"], "op": "replace"}]'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301133

[Darja Shakhray (dshakhray)]

I do not think the status of bug "fix released", because commit does not merged

[Bhargavi (bhargavi-c81)]

am unable to change status from "fix released" to "confirm".

[Darja Shakhray (dshakhray)]

I think the status "in progress", because commit on review https://review.openstack.org/#/c/301133/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302003

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302654

[Anseela M M (anseela-m00)]

I have created test cases for verifying the bug. Please execute these test cases once the fix is done.

Test case id: OPNST_ glance Bug:1555662 Excess update tags_1

Metric: 30 minutes

Test purpose: Verify that patch request should not send excess update tags while updating the glance image

Configuration: An OpenStack environment with at least one controller (with keystone, glance), one compute node and one network node installed.

Test tool: tempest

References: Bug_ 1555662 _ Excess update tags

Applicability: If the user trying the update any property of image, the issue exists

Pre-test conditions: Openstack should be installed and all the services up and running

Step Description:
1. create an image
2. list the images glance image-show
3. Add the tag
4. Update any property (glance image-update)
5. Check the patch request by giving –debug command
Result:
1. User should be able to create the image
2. User should be able to list the created image
3. User should be able to add the tag
4. User should be able to update the properly.
5. PATCH request should have replace property field
6. Should not contains excess tags

Test verdict: TC pass only if user can update the image and patch request contains only the replace property

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bhargavi (<email address hidden>) on branch: master
Review: https://review.openstack.org/301133
Reason: did not follow commit message standards.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hemanth Makkapati (<email address hidden>) on branch: master
Review: https://review.openstack.org/302003
Reason: No recent activity, hence abandoning this. Please feel free to resurrect this when appropriate.

[Brian Rosmaita (brian-rosmaita)]

Resetting this bug due to no activity on associated patches so that someone else can pick it up.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brian Rosmaita (<email address hidden>) on branch: master
Review: https://review.openstack.org/302654
Reason: No activity in >1 year.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-glanceclient/+/859613