SM : Purging the packages leaves the server manager process to run

[sundarkh]

SM : Purging the packages leaves the server manager process to run

1) Install Server Manager , ./setup.sh --al l under /opt/contrail/ServerManager
2) Make sure the process is runing,under ps -eaf | grep contrail , lets says PID is 4000
3) Now, Purge the Server Manager package, using dpkg -P <ServerManagerPackage>
4)Observe that the PID of Server Manager is still alive (PID 4000)

Impact :

During ServerManager upgrade, when the SM admin, purges the packages , and installs the new server manager , New Server Manager does not start (due to the old PID is alive)

There should be a error message, that the old SM process is still alive

[sundarkh (sundar-kh)]

"2016-03-15 00:51:00,025-DEBUG-server_mgr_main.py:2666-reimage_server(): reimage_server"
"2016-03-15 00:51:00,026-DEBUG-server_mgr_main.py:1047-validate_smgr_request(): validate_smgr_request"
"2016-03-15 00:51:00,028-DEBUG-server_mgr_main.py:1072-validate_smgr_request(): ret_val_data returned: {'status': 0, 'match_key': 'cluster_id', 'do_reboot': True, 'match_value': u'cluster_multi', 'package_image_id': None, 'base_image_id': u'ubuntu-14-04'}"
"2016-03-15 00:51:00,070-DEBUG-server_mgr_main.py:2837-reimage_server(): reimage queued. Number of servers reimaged is 4:"
"2016-03-15 00:51:00,282-DEBUG-server_mgr_main.py:2954-_reimage_server_cobbler(): reimage processed from queue"
"2016-03-15 00:51:00,497-DEBUG-server_mgr_main.py:2954-_reimage_server_cobbler(): reimage processed from queue"
"2016-03-15 00:51:00,726-DEBUG-server_mgr_main.py:2954-_reimage_server_cobbler(): reimage processed from queue"
"2016-03-15 00:51:00,948-DEBUG-server_mgr_main.py:2954-_reimage_server_cobbler(): reimage processed from queue"
"2016-03-15 00:51:00,948-DEBUG-server_mgr_main.py:2976-_reimage_server_cobbler(): reimage_server_cobbler failed: list index out of range

Faced again this issue,with R2.21.x-29 Juno

1) SM had a running mainline 2720 2) Installed 2.21.x-29 juno sanity got triggered , and server manager got installed
3) But the server manager process still pointed to old pid , restricting the new SM process to initiate (User is unaware of this , since no error message comes)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18446
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18447
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18446
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18447
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18446
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18446
Committed: http://github.org/Juniper/contrail-packaging/commit/2ab370b2a3468bcece9b627c6e77ca569a94476b
Submitter: Zuul
Branch: master

commit 2ab370b2a3468bcece9b627c6e77ca569a94476b
Author: Dheeraj Gautam <email address hidden>
Date: Tue Mar 15 09:39:14 2016 -0700

SM-INSTALL: restart server-manager on upgrade

Closes-Bug: #1555601

CHANGES:
1. restart contrail-server-manager for upgrade case.
2. added "x" while checking for status of contrail-webui.

Testing:
1. upgraded 2718 to 2720 and verified server-manager was restarted and its
output was logged into log file.
2. no error was reported about syntax (supervisor-webui service not
available).

PATCH2:
updated code to resolve review comments.

PATCH3:
recified indentation.

PATCH4:
Addressed review comments

Change-Id: I2503963d6ec769920a3ede17be77cf03913e5795

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18447
Submitter: Dheeraj Gautam (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18447
Committed: http://github.org/Juniper/contrail-packaging/commit/929529929df36038031458c44c0a3e063235bb71
Submitter: Zuul
Branch: R3.0

commit 929529929df36038031458c44c0a3e063235bb71
Author: Dheeraj Gautam <email address hidden>
Date: Tue Mar 15 09:39:14 2016 -0700

SM-INSTALL: restart server-manager on upgrade case

Closes-Bug: #1555601

CHANGES:
1. restart contrail-server-manager for upgrade case.
2. added "x" while checking for status of contrail-webui.

Testing:
1. upgraded 2718 to 2720 and verified server-manager was restarted and its
output was logged into log file.
2. no error was reported about syntax (supervisor-webui service not
available).

PATCH2:
updated code to resolve review comments.

PATCH3:
rectified the indentation of the code.

PATCH4:
Addressed review comments

Change-Id: I2503963d6ec769920a3ede17be77cf03913e5795