image gallery display bug in Safari 8.0.4

[Yezi]

1. The arrows of image gallery to go back and forward appears at the top of the photo, while it should be in the middle of the photos.

2. The photo in the image gallery is collapsed with the content below it. Then, if I click “edit the page”, content below the image gallery display in the right place. Then, if I click “display the page”, the display goes wrong again in Sarari 8.0.4. However, in earlier version of Safari, if I click “display the page” after "edit the page", the image gallery and content below it display correctly.

[Kristina Hoeppner (kris-hoeppner)]

Can you please provide a screenshot and the version of Mahara you were testing?

[Kristina Hoeppner (kris-hoeppner)]

A screenshot is available at https://bugs.launchpad.net/mahara/+bug/1554923/+attachment/4593442/+files/Mahara%20default%20theme%20bug%20in%20page%20layout.pdf on bug #1554923

[Kristina Hoeppner (kris-hoeppner)]

Also see description at bug #1554576 as the issue seems to affect other browsers as well.

[Yezi (yezi-yang08)]

The attachment is the screen shot of the bug in image gallery.

[Domi Sinclair (domi-sinclair)]

This is a screenshot which exemplifies the problems we have been having, also with this bug. We have replicated it in Chrome (v49) and Firefox (v44). Refreshing seems to sometimes fix the problem, sometimes not.

[Robert Lyon (robertl-9)]

In 15.04 the gallery had it's own js file to handle the display of the slideshow

In 15.10 we went with the inbuilt bootstrap way of doing the display so I'm guessing there is something with the bootstrap way that is failing for certain browsers or failing under certain conditions.

[Robert Lyon (robertl-9)]

I can sort of replicate this issue sometimes in firefox but on page refresh the issue goes away.

I have a folder of images that contain images of different height / width. some are tall and thin, some are short and wide.

If the first image is short and wide but the last image is tall and thin sometimes the gallery arrows are displayed near the top, like the galley was expecting only short images.

I wonder if it is due to the browser not knowing the height of the images until after they have been loaded as we don't pass the height/width of the image in the <img> tag?

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6404

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6404
Committed: https://git.mahara.org/mahara/mahara/commit/e68eb006d9c81773e985aa7019f857a73603b34b
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit e68eb006d9c81773e985aa7019f857a73603b34b
Author: Pat Kira <email address hidden>
Date: Wed Apr 27 13:24:33 2016 +1200

bug 1555407 - Fixed overlapping carousel in collapsible block

behatnotneeded

Change-Id: I105728bdc5ed9c500e86efc99965c3936e543f17

[Mahara Bot (dev-mahara)]

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6429

[Mahara Bot (dev-mahara)]

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6432

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6429
Committed: https://git.mahara.org/mahara/mahara/commit/ce8d2838d6d875513c89a543c1bd894a08e5f09b
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit ce8d2838d6d875513c89a543c1bd894a08e5f09b
Author: Pat Kira <email address hidden>
Date: Wed Apr 27 13:24:33 2016 +1200

bug 1555407 - Fixed overlapping carousel in collapsible block

behatnotneeded

Change-Id: I105728bdc5ed9c500e86efc99965c3936e543f17

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6432
Committed: https://git.mahara.org/mahara/mahara/commit/ee506f2a193efc349850a9e44bc32aa9b62fa6b1
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit ee506f2a193efc349850a9e44bc32aa9b62fa6b1
Author: Pat Kira <email address hidden>
Date: Wed Apr 27 13:24:33 2016 +1200

bug 1555407 - Fixed overlapping carousel in collapsible block

behatnotneeded

Change-Id: I105728bdc5ed9c500e86efc99965c3936e543f17