Neutron too coupled with Tempest

[Assaf Muller]

I recently dropped Tempest 'plumbing' code from Neutron and imported it instead from Tempest: https://review.openstack.org/#/c/269771/

Since then, we've had two instances of changes to Tempest breaking the Neutron API tests:
https://bugs.launchpad.net/neutron/+bug/1554362, and:
https://review.openstack.org/#/c/284911/

Neutron imports the following files from Tempest (That aren't a stable interface e.g. in tempest.lib) that Manila and Ironic (As examples of projects that have Tempest plugins) do not:

from tempest.services.identity.v2.json.tenants_client import TenantsClient

Instead of waiting for the next breakage, we should go through each such import and figure out a strategy to stop using it:
1) Perhaps there is already equivalent code in tempest.lib?
2) If not, can we help move it to tempest.lib?
3) Failing that, we can always copy the needed functionality in to Neutron

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/290920

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/290929

[Ihar Hrachyshka (ihar-hrachyshka)]

I think it's fair to say it's worth considering getting at least some of those pieces in Mitaka, if possible, since it will help us avoid later stable branch breakages that may result from new tempest changes [note that tempest is not branched so we are still affected by master changes.]

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290929
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ee3dc409bc3633f8477bce8998add9dadaf6543d
Submitter: Jenkins
Branch: master

commit ee3dc409bc3633f8477bce8998add9dadaf6543d
Author: Assaf Muller <email address hidden>
Date: Wed Mar 9 19:59:47 2016 -0500

    Remove unused Tempest AdminManager

    Change-Id: If1c5983bdad63121cb7a8ab1d97b16f389ebfe09
    Related-bug: #1555356

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3ba14bb099baa6982894dee2a4a4a7bd3a5f0b96
Submitter: Jenkins
Branch: master

commit 3ba14bb099baa6982894dee2a4a4a7bd3a5f0b96
Author: Assaf Muller <email address hidden>
Date: Wed Mar 9 18:59:20 2016 -0500

    Copy tempest.common.tempest_fixtures in to Neutron

    tempest_fixtures is used exclusively in Tempest and Neutron,
    therefor I don't think it makes sense to move it in to tempest.lib.
    I'd rather copy it in to the Neutron repo.

    Change-Id: Ibb52e2cae3f1af1569a04123c43ebc4d125e326d
    Related-bug: #1555356

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/304324

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304324
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=965e1d18a732f54455d588db2e98207fbe6b2d5a
Submitter: Jenkins
Branch: master

commit 965e1d18a732f54455d588db2e98207fbe6b2d5a
Author: Armando Migliaccio <email address hidden>
Date: Mon Apr 11 15:04:12 2016 -0700

    Move away from invoking api tests explicitly

    Since adoption of the Tempest plugin framework, this
    extra plumbing is no longer necessary in tree.

    Related-bug: 1555356

    Depends-on: If5f7ea82c45494953452f728fabb7403d0b6e14e
    Change-Id: I5377f33c5a7b29f97f00878e048d154378a4fe34

[Ihar Hrachyshka (ihar-hrachyshka)]

Should we postpone that one to O? I don't think it's RC1 material.

[Armando Migliaccio (armando-migliaccio)]

We have not broken the API job in a while. For accidental breakages we might as well track the root causes individually. I'd close this umbrella bug that's never gonna have a chance to see 'Fix Released'.

[Launchpad Janitor (janitor)]

[Expired for neutron because there has been no activity for 60 days.]