Fix bashism in NovaEvacuate

Bug #1555020 reported by Norbert Illes
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
openstack-resource-agents
In Progress
Medium
Norbert Illes

Bug Description

Tox syntax-check is failing because of a bashism in NovaEvacuate.

$ tox -e syntax-check
syntax-check installed:
syntax-check runtests: PYTHONHASHSEED='1152052790'
syntax-check runtests: commands[0] | bash -c /home/eillnor/work/openstack-resource-agents/utils/syntax_check.sh -a -p
possible bashism in /tmp/tmp.cRSar6D0il line 259 (<() process substituion):
        attrd_updater -n evacuate -A \
            2> >(grep -v "attribute does not exist" 1>&2) |
Syntax Test FAILED: syntax errors found in the following files:

/home/eillnor/work/openstack-resource-agents/ocf/NovaEvacuate
ERROR: InvocationError: '/bin/bash -c /home/eillnor/work/openstack-resource-agents/utils/syntax_check.sh -a -p'
__________________________________ summary __________________________________

ERROR: syntax-check: commands failed

Norbert Illes (nilles)
Changed in openstack-resource-agents:
assignee: nobody → Norbert Illes (nilles)
description: updated
Norbert Illes (nilles)
Changed in openstack-resource-agents:
status: New → In Progress
Revision history for this message
Adam Spiers (adam.spiers) wrote :
Revision history for this message
Adam Spiers (adam.spiers) wrote :
Revision history for this message
Vincent Untz (vuntz) wrote :

Adam: I might be wrong, but I think I found some of these links when I was trying things, and they didn't really match what is needed. But feel free to try :-)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-resource-agents (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290543

Revision history for this message
Norbert Illes (nilles) wrote :

This seems ok in my manual tests, please give it a try if you can, to see if it's really work as expected.

Changed in openstack-resource-agents:
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.