Nailgun silently ignores extension load failure

[Yuriy Taraday]

If extension fails to load (due to ImportError or error in some initialization logic within the extension) Nailgun silently ignores such error.

We should make Nailgun fail if one of extensions fails.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Sylwester Brzeczkowski (sbrzeczkowski)]

ExtensionManager should get 'on_load_failture_callback' argument with function which will raise some custom "CannotLoadExtensionError" or something.

[0] https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/extensions/manager.py#L38-L39

[Yuriy Taraday (yorik-sar)]

In Octane we do this by just raising the exception that is being handled in on_load_failure_callback: https://github.com/openstack/fuel-octane/blob/master/octane/handlers/__init__.py#L25

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304867

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/304867
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b20d67712e6815f709b0ab80f393e1c2303906d1
Submitter: Jenkins
Branch: master

commit b20d67712e6815f709b0ab80f393e1c2303906d1
Author: Ryan Moe <email address hidden>
Date: Tue Apr 12 13:47:19 2016 -0700

    Don't ignore failure to load extensions

    When an extension fails to load a message will be logged along with
    the exception raised by the extension. The exception will be
    re-raised.

    Change-Id: Ic8e8931a34f59102dbcd1f5c5dc48d562cabedff
    Closes-bug: #1555005

[Yuriy Taraday (yorik-sar)]

Why is this change in "Won't fix" for mitaka? It causes some pain for mitaka development.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360513

[Yuriy Taraday (yorik-sar)]

Bug has been reintroduced in master by https://review.openstack.org/342880

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/mitaka
Review: https://review.opendev.org/360513
Reason: This repo is retired now, no further work will get merged.