External DNS driver fails with Python 3.4 with an index computed with a division operation when slicing a string

Bug #1554922 reported by Miguel Lavalle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Miguel Lavalle

Bug Description

The external DNS driver for Designate has method _get_in_addr_zone_name that utilizes a division operation to compute an index to slice a string. The string slicing fails if the index is not explicitly converted to int in python 3.4

Tags: dns py34
Revision history for this message
Miguel Lavalle (minsel) wrote :

This makes python 3.4 unit tests to fail

Changed in neutron:
importance: Undecided → Medium
assignee: nobody → Miguel Lavalle (minsel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290303

Changed in neutron:
status: New → In Progress
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Could you please point to the failure logs?

tags: added: dns py34
tags: added: gate-failure
Changed in neutron:
milestone: none → mitaka-rc1
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

OK, my understanding now is that there is no gate error for existing tests, just for new tests to be introduced. That lowers the priority here, since we never said neutron is ready to actually run with python3.

Changed in neutron:
milestone: mitaka-rc1 → none
tags: removed: gate-failure
Changed in neutron:
milestone: none → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/290303
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2dc6cb7b8d60171eb6c9edb395b3476a35c1eab2
Submitter: Jenkins
Branch: master

commit 2dc6cb7b8d60171eb6c9edb395b3476a35c1eab2
Author: Miguel Lavalle <email address hidden>
Date: Wed Mar 9 06:39:51 2016 +0000

    Fixes external DNS driver failure with Python 3.4

    The external DNS driver uses an index computed with a division to slice strings
    when calculating PTR records. In Python 3.4, this division returns a float
    instead of an int, which causes the slice operation to fail leading to Python
    3.4 unit tests to fail in Jenkins

    Change-Id: I15ec039a095e00db9087b67557f9fab997e48648
    Closes-Bug: 1554922

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0rc1

This issue was fixed in the openstack/neutron 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.