Many legacy eslint warnings swamp actual errors

[Richard Jones]

Horizon's eslint output currently has many hundreds of warnings which drown out any linting output for new code.

[Richard Jones (r1chardj0n3s)]

A *lot* of the warnings are about jsdoc errors, but we need to have a conversation about documenting our Javascript before those should be addressed. Also, the governance for this specifically says we should be using Sphinx. So there.

http://governance.openstack.org/reference/cti/javascript-cti.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290235

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290738

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290041
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=74fe0ac371ebbb45466c9fe7af07d4e255516638
Submitter: Jenkins
Branch: master

commit 74fe0ac371ebbb45466c9fe7af07d4e255516638
Author: Matt Borland <email address hidden>
Date: Tue Mar 8 10:36:52 2016 -0700

    Cleaning code to remove eslint warnings from Launch Instance

    Cleans up eslint warnings.

    Change-Id: I920f434c008c4679ce5758c70031d1ec5d26a2b7
    Partial-Bug: 1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290738
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=09148f68d62829f943438215b459f8754ccce536
Submitter: Jenkins
Branch: master

commit 09148f68d62829f943438215b459f8754ccce536
Author: Matt Borland <email address hidden>
Date: Wed Mar 9 11:07:40 2016 -0700

    Cleaning up eslint warnings in the openstack-service-api directory

    There are many eslint warnings in this directory. This patch cleans
    them up, about 100 warnings removed.

    Change-Id: I639dccd7b511190552f05ae0e52234532412e54c
    Partial-Bug: 1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289570
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=adc9ab14cfdd385edfec18020ad87dfdb6d46a55
Submitter: Jenkins
Branch: master

commit adc9ab14cfdd385edfec18020ad87dfdb6d46a55
Author: Matt Borland <email address hidden>
Date: Mon Mar 7 14:16:03 2016 -0700

    Cleaning up lint warnings for Image work

    This patch simply cleans up eslint warnings for the Angular Image work.
    Please note, we still have many warnings due to injectables apparently
    needing documentation; I'd prefer to not have to redocument all the
    injectables. So there are still warnings, but all of the same type.

    Change-Id: Iea465225b725d7378ecab48571d59fc323848d3e
    Partial-Bug: 1554824

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/290235
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/346244

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/346246

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/346250

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/346265

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/346270

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/347001

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346241
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7cbd3b7019ad14a04b59efc360579fa386419162
Submitter: Jenkins
Branch: master

commit 7cbd3b7019ad14a04b59efc360579fa386419162
Author: woodm1979 <email address hidden>
Date: Fri Jul 22 15:22:22 2016 -0600

    No more space-in-parens eslint errors

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "space-in-parens" errors.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: Ie9292da293eea6a93751e6c17d24068b66c5d62a
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346250
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4f1b6c48760fb578e86ad771a666acbd7b70aa4a
Submitter: Jenkins
Branch: master

commit 4f1b6c48760fb578e86ad771a666acbd7b70aa4a
Author: woodm1979 <email address hidden>
Date: Fri Jul 22 16:08:47 2016 -0600

    No more block-scoped-var eslint errors

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "block-scoped-var" errors.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: I8edff5f0c6fb90e8600a1d047f225900ef85baba
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346246
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6cc5ce1fa79449ee7e1bc44f040097c78e25cda8
Submitter: Jenkins
Branch: master

commit 6cc5ce1fa79449ee7e1bc44f040097c78e25cda8
Author: woodm1979 <email address hidden>
Date: Fri Jul 22 15:49:00 2016 -0600

    No more no-extra-parens eslint errors

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "no-extra-parens" errors.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: I634eafd359b14f40b89c2b30995557432cbb1b99
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346270
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e75978352a31d623efd6cef5877ad413969b0e0c
Submitter: Jenkins
Branch: master

commit e75978352a31d623efd6cef5877ad413969b0e0c
Author: woodm1979 <email address hidden>
Date: Fri Jul 22 17:02:41 2016 -0600

    No more no-unneeded-ternary eslint errors

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "no-unneeded-ternary" errors.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: I0d6d104560dc3b6cc10cc3ff00e45230ce5fa836
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/347001
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b3658f76bcb04108288d64ef63eecb8bc0a4992a
Submitter: Jenkins
Branch: master

commit b3658f76bcb04108288d64ef63eecb8bc0a4992a
Author: woodm1979 <email address hidden>
Date: Mon Jul 25 13:52:26 2016 -0600

    No eslint errors in horizon.heattop.js

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "no-use-before-define" errors in the
    horizon/static/horizon/js/horizon.heattop.js file.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: I347a472a0eac2e35df14e48f28403a3b8a243c57
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/346244
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c3fd32b8eb360c6916c70ae021e9b404498ac691
Submitter: Jenkins
Branch: master

commit c3fd32b8eb360c6916c70ae021e9b404498ac691
Author: woodm1979 <email address hidden>
Date: Fri Jul 22 15:38:20 2016 -0600

    No more braces-style eslint errors

    Running eslint is effectively useless nowdays because of the
    overwhelming number of warnings returned.

    This patch fixes the existing "braces-style" errors.

    I've decided to only fix those errors here to keep the patch small, and
    not destroy any chance of success by needing to rebase every 5 minutes.
    Other fixes will be incoming.

    Change-Id: I0cc2772287ce3f4b3ddb808764dd8d9b1c569d02
    Partial-Bug: #1554824

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/346265
Reason: Due to inactivity