Subscription update in Redis driver doesn't pack new options in msgpack

Bug #1554683 reported by Eva Balycheva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zaqar
Fix Released
High
Eva Balycheva

Bug Description

What happens:
If you try to update subscription in Redis and specify new options, these options will be written to database in plain text format instead of msgpack format.
Then, if you try to get this subscription, Zaqar will just return response with code 503.

Proofs:
Curl requests:
http://paste.openstack.org/show/aCCiZAntO4okXz2RgO90/

Part of Zaqar's log during get request:
http://paste.openstack.org/show/3mCl6Mnpv3zSCmAybzyQ/

Possible solution:
Make Zaqar on subscription update operation pack options in msgpack format before sending it to Redis database.

Eva Balycheva (ubershy)
Changed in zaqar:
assignee: nobody → Eva Balycheva (ubershy)
Feilong Wang (flwang)
Changed in zaqar:
milestone: none → mitaka-rc1
tags: added: release-critical
Changed in zaqar:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zaqar (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290170

Changed in zaqar:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zaqar (master)

Reviewed: https://review.openstack.org/290170
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=146e37c70f0bb765b7f467c2b3ad2d1754e264db
Submitter: Jenkins
Branch: master

commit 146e37c70f0bb765b7f467c2b3ad2d1754e264db
Author: Eva Balycheva <email address hidden>
Date: Wed Mar 9 01:37:57 2016 +0300

    Fix updating subscription options in Redis driver

    Now, if you try to update subscription in Redis and specify new options,
    these options will be written to database in plain text format instead
    of MessagePack format.
    Then, if you try to get this subscription, Zaqar will return response
    with code 503. Internally Zaqar will experience a problem while trying
    to unpack subscription's options.

    This patch makes Redis driver on HTTP PATCH method pack subscription
    options in MessagePack format, before sending changes to database.

    Change-Id: Ic3940b5093021c0d0cc5c345acabe29804d5a291
    Closes-Bug: 1554683

Changed in zaqar:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/zaqar 2.0.0.0rc1

This issue was fixed in the openstack/zaqar 2.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.