Test settings are importing local/enabled.

Bug #1554513 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Wang Bo

Bug Description

The test settings are importing openstack_dashboard.local.enabled. This shouldn't be imported for tests, as the tests should only be testing openstack_dashboard, not whatever plugins happen to be installed at the time.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
Changed in horizon:
importance: Undecided → Low
milestone: none → newton-1
Revision history for this message
Wang Bo (chestack) wrote :

I came into this issue When to run test case but enabled "serachlight_ui".

I proposed a patch to remove this importing.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/318591

Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Wang Bo (chestack)
status: New → In Progress
Revision history for this message
Wang Bo (chestack) wrote :

Sorry for did not talk to you firstly but proposed the patch yet.

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

No problem. I'd not pushed my patch, so its better to get it fixed. Thanks!

Changed in horizon:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/318591
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f5c41b609fd2cfc1705b55378b74583984ccc64d
Submitter: Jenkins
Branch: master

commit f5c41b609fd2cfc1705b55378b74583984ccc64d
Author: wangbo <wangbo_bupt@163.com>
Date: Thu May 19 19:37:59 2016 +0800

    Do not import local/enabled when to run test

    For horizon, it should only test openstack_dashboard exclude any plugin.

    It throws error "can not find app searchlight_ui" When I run test
    with enabling searchlight_ui plugin.

    Change-Id: I203685fdafd577068769f2e362ecb2ef5385b207
    Closes-Bug: #1554513

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b3

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.