Move launchconfig reference checking to validate()

Bug #1554311 reported by huangtianhua
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua

Bug Description

There is a user case: The aws asg resource doesn't have a dependency on the launchconfiguration resource. This can happen if the the actual resource name is used instead of {get_resource: launch_conf} and no depends_on is used.

Now we have a check for launchconfig reference in handle_create(), need to move this check to validate() to make sure we can check when aws asg update.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290247

Changed in heat:
status: New → In Progress
Changed in heat:
milestone: none → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/290247
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ee086961a631b7af8ae8b7a215e337a6020eef34
Submitter: Jenkins
Branch: master

commit ee086961a631b7af8ae8b7a215e337a6020eef34
Author: huangtianhua <email address hidden>
Date: Tue Mar 8 17:16:23 2016 +0800

    Move launchconfig reference validation to validate()

    Now we do launchconfig reference check for
    AWS::AutoScaling::AutoScalingGroup and OS::Heat::InstanceGroup
    resources only in handle_create(), this patch moves the
    check to validate(), then the validation will work when
    resource update.

    Change-Id: I727c7155ce708a11184aad6fea36a365f1022c92
    Closes-Bug: #1554311

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0rc1

This issue was fixed in the openstack/heat 6.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.