EasyWorship import throws exception on unknown character
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Medium
|
Tomas Groth | ||
2.4 |
Fix Released
|
Undecided
|
Tomas Groth |
Bug Description
When importing from a EasyWorship DB the user selects an encoding to use for the imported text. If the importer encounters an unknown character it currently throws the exception shown below. This should be handled better, for example by creating an error entry in the import-log.
See https:/
Traceback (most recent call last):
File "/home/
self.
File "/home/
importer.
File "/home/
self.
File "/home/
self.copyright = copy.decode(
File "/usr/lib/
return codecs.
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 45: character maps to <undefined>
Related branches
- Tim Bentley: Approve
- Raoul Snyman: Approve
-
Diff: 239 lines (+76/-44)7 files modifiedopenlp/core/ui/exceptionform.py (+6/-4)
openlp/plugins/custom/forms/editcustomform.py (+1/-0)
openlp/plugins/songs/lib/importers/easyworship.py (+40/-32)
openlp/plugins/songs/lib/mediaitem.py (+2/-2)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+2/-2)
tests/interfaces/openlp_core_lib/test_pluginmanager.py (+9/-4)
tests/interfaces/openlp_plugins/custom/forms/test_customform.py (+16/-0)
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 336 lines (+109/-48)12 files modifiedopenlp/core/ui/exceptionform.py (+6/-4)
openlp/plugins/bibles/lib/http.py (+1/-1)
openlp/plugins/bibles/lib/mediaitem.py (+3/-0)
openlp/plugins/bibles/lib/zefania.py (+2/-1)
openlp/plugins/custom/forms/editcustomform.py (+1/-0)
openlp/plugins/songs/lib/__init__.py (+2/-1)
openlp/plugins/songs/lib/importers/easyworship.py (+40/-32)
openlp/plugins/songs/lib/importers/songimport.py (+1/-1)
tests/functional/__init__.py (+3/-3)
tests/functional/openlp_plugins/songs/test_lib.py (+25/-1)
tests/interfaces/openlp_core_lib/test_pluginmanager.py (+9/-4)
tests/interfaces/openlp_plugins/custom/forms/test_customform.py (+16/-0)
Changed in openlp: | |
assignee: | nobody → Tomas Groth (tomasgroth) |
status: | Confirmed → In Progress |
Changed in openlp: | |
milestone: | none → 2.5.1 |
status: | In Progress → Fix Committed |