string in nova.service.js cannot control the word order in translations Edit Bug

Bug #1553619 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

openstack_dashboard/static/app/core/openstack-service-api/nova.service.js

      return suppressError ? promise : promise.error(function() {
        toastService.add('error', gettext('Unable to delete the flavor with id: ') + flavorId);
      });

String concatenation should not be used.
https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#interpolate

Tags: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/288947

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/288947
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=075d9b3624d33c924a88e0d1b77e87378d770f86
Submitter: Jenkins
Branch: master

commit 075d9b3624d33c924a88e0d1b77e87378d770f86
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 6 08:27:49 2016 +0900

    Use interpolate in JS to allow translators to control word order

    String concatenation is not recommended for better translation.

    Change-Id: I56cd604d88693dadc85ec06f4b4220a63151f2ee
    Closes-Bug: #1553619

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0rc1

This issue was fixed in the openstack/horizon 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.