Strange panel name "NGContainers"

Bug #1553612 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones

Bug Description

We have a panel named "NGContainers", but "NG" means AngularJS based implementation.
It is completely meaningless for dashboard users.
It should have more meaningful name.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/288948

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

The naming scheme is tricky, yes, but it is also a pattern we've used for other AngularJS panels. "NG" for Angular but also "Next Generation" in my mind. Do you have a suggestion for a better name?

We intend to replace the Containers panel with NGContainers when it is merged. This may happen for Mitaka, depending on review speed.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I know we are developing the Containers panel with AngularJS and now we have two Containers panel.
I think the name "NGContainers" is chosen so that developers can distinguish two panels easily.

My comment is from the point of view of regular users.
For regular users, "NGContainers" is completely meaningless. They cannot understand what "NGContainers" means.

If the new panel lands by Mitaka-RC1, can we ensure to replace "NGContainers" with "Containers"?
If it does not land, is "NGContainers" never visible to users?

We have started translations for Mitaka, so at least we should add a comment for translators so that they can know how "NGContainers" should be treated (perhaps no need to translate it because it is under development and never visible to users).

Thought?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/289106

Changed in horizon:
assignee: Akihiro Motoki (amotoki) → Richard Jones (r1chardj0n3s)
Revision history for this message
Akihiro Motoki (amotoki) wrote :

I am a bit surprised that you proposed a patch replacing the old containers panel with the new angular one.
What I would like to take care of this bug is the only one string visible to users ("NGContainers").
URL or other stuff does not need to be renamed.

Is the Angular version of the panel ready? I am okay with either direction.

Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

Oh! Sorry, I was creating that patch while you were explaining and I didn't notice your follow-up! I'll address the simple problem you have, but I'm going to leave the more "complete" patch up for later discussion and merging :-)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/289124

Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

Argh. Sorry.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Richard Jones (<email address hidden>) on branch: master
Review: https://review.openstack.org/289124

Revision history for this message
Akihiro Motoki (amotoki) wrote :

No problem. Thanks for you support anyway!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/288948
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b09f0e8c63feaabab96a0f96bc5b8f2782fc9d87
Submitter: Jenkins
Branch: master

commit b09f0e8c63feaabab96a0f96bc5b8f2782fc9d87
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 6 08:30:10 2016 +0900

    Rename a panel name "NGContainers" with "Containers"

    "NGContainers" is meaningless from dashboard users
    since "NG" means AngularJS based implementation.
    Users do not care what implementation is used and
    this kind of naming should be avoided.

    Change-Id: I240316403a1f448ffcdad7da6f3197531550613b
    Closes-Bug: #1553612

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0rc1

This issue was fixed in the openstack/horizon 9.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.