ospurge doesn't remove DVR router interfaces

[Jonas]

When DVR is enabled in Neutron (router_distributed = True), ospurge doesn't remove the router interfaces and as a consequence fails to remove the routers.

The reason as far as I can see is in line 213 in client.py. Rather than:

    if port["device_owner"] == "network:router_interface"

it should look something like

 if port["device_owner"] in ("network:router_interface", "router_interface_distributed")

[Juha Rajamaki (jurajama)]

The proposed fix is otherwise ok, but it has a little bug of the second item of dictionary missing "network:" prefix. It should be:

  if port["device_owner"] in ("network:router_interface", "network:router_interface_distributed")

[Juha Rajamaki (jurajama)]

Code review: https://review.openstack.org/#/c/399963/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399963
Committed: https://git.openstack.org/cgit/openstack/ospurge/commit/?id=d18f6617b476ca667c468104d76b0c205551d6a1
Submitter: Jenkins
Branch: master

commit d18f6617b476ca667c468104d76b0c205551d6a1
Author: jurajama <email address hidden>
Date: Mon Nov 7 14:47:13 2016 +0200

    Fix to delete router interfaces with DVR enabled

    Now also interfaces with owner "network:router_interface_distributed" are deleted.
    Before this fix, interface and router deletion failed if DVR is enabled.

    Change-Id: I33c5304845d4d7c2eee729aa334ec745dcac970e
    Closes-Bug: #1552336