2723: agent crashed at FlowTable::Update(FlowEntry*, FlowEntry*)

[Ankit Jain]

This crash happened while testing port mirroring for the following scenario:

                     analyzer1, analyzer2, analyzer3

                                     | | |

                                          svcinst1

                   -------------------------------------------
                 Mirroring
                         |

leftvm 10.1.1.3 -----------------------20.1.1.3 right vm

#1 0x0000000000c23cad in FlowTable::Update(FlowEntry*, FlowEntry*) ()
#2 0x0000000000c39084 in FlowProto::UpdateFlow(FlowEntry*) ()
#3 0x0000000000c44a21 in PktFlowInfo::Add(PktInfo const*, PktControlInfo*, PktControlInfo*) ()
#4 0x0000000000c52cd2 in FlowHandler::Run() ()
#5 0x0000000000c4f158 in Proto::ProcessProto(boost::shared_ptr<PktInfo>) ()
#6 0x0000000000c3b6fd in FlowProto::FlowEventHandler(FlowEvent*, FlowTable*) ()
#7 0x0000000000c3db2f in QueueTaskRunner<FlowEvent*, WorkQueue<FlowEvent*> >::Run() ()
#8 0x000000000119345c in TaskImpl::execute() ()
#9 0x00007f82e5b04b3a in ?? () from /usr/lib/libtbb.so.2
#10 0x00007f82e5b00816 in ?? () from /usr/lib/libtbb.so.2
#11 0x00007f82e5afff4b in ?? () from /usr/lib/libtbb.so.2
#12 0x00007f82e5afc0ff in ?? () from /usr/lib/libtbb.so.2
#13 0x00007f82e5afc2f9 in ?? () from /usr/lib/libtbb.so.2
#14 0x00007f82e5d20182 in start_thread (arg=0x7f82dc9b5700) at pthread_create.c:312
#15 0x00007f82e4ff947d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

vm2
 ubuntu

    20.1.1.3

 m1.small - Active nova None Running 0 minutes

vm1
 ubuntu

    10.1.1.3

 m1.small - Active nova None Running 0 minutes

analyzer_test-3
 analyzer

    30.1.1.4

 m1.medium - Active nova None Running 17 minutes

analyzer_test-2
 analyzer

    30.1.1.5

 m1.medium - Active nova None Running 17 minutes

analyzer_test-1
 analyzer

    30.1.1.3

 m1.medium - Active nova None Running 17 minutes

core copied at /cs-shared/bugs/<bug-id> on any blr shell server (ex nodeb6)

[Manish Singh (manishs)]

Packet is received by agent to resolve ECMP index. Because its a request for resolve, update is issued, however when request is processed flow is deleted.
NUL check needed for flow in lock.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18607
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18607
Committed: http://github.org/Juniper/contrail-controller/commit/54ee5543c611365729d550793a23b3714c4a9acc
Submitter: Zuul
Branch: master

commit 54ee5543c611365729d550793a23b3714c4a9acc
Author: Manish Singh <email address hidden>
Date: Tue Mar 22 11:58:32 2016 +0530

Handle NULL flow in FLOW_LOCK.

Change-Id: I8a202aca7dc7a7fd1bf86509b3509697b5e51f62
Closes-bug: #1552203

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18810
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18810
Committed: http://github.org/Juniper/contrail-controller/commit/fb0af42b1c2b66d8982b0de52fca431bdc49f5a0
Submitter: Zuul
Branch: R3.0

commit fb0af42b1c2b66d8982b0de52fca431bdc49f5a0
Author: Manish Singh <email address hidden>
Date: Tue Mar 22 11:58:32 2016 +0530

Handle NULL flow in FLOW_LOCK.

Change-Id: I8a202aca7dc7a7fd1bf86509b3509697b5e51f62
Closes-bug: #1552203