network interface changes don't initiate a restart

[Andy McCrae]

When changing network interface options (e.g. adding static_routes) the task to make changes on the container doesn't initiate a restart of the interface or of the container itself.

This means the static_routes are never actually adopted unless you go afterward to restart the container/networking manually, or are lucky enough to have a task that fires a restart.

Due to the nature of the task itself, and being a flat "container_command" we can't use notify so will have to perform some type of check in the command itself.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/286078

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/286078
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-lxc_container_create/commit/?id=c2f43ebb7dcee8b800df9f4b8c638ae58d6476d9
Submitter: Jenkins
Branch: master

commit c2f43ebb7dcee8b800df9f4b8c638ae58d6476d9
Author: Andy McCrae <email address hidden>
Date: Mon Feb 29 13:57:25 2016 +0000

    Restart containers on network configuration change

    Changes to the network configuration need to cause a restart of the
    interface for the changes to take place.

    We can check the md5sum of the network interface config before and after
    the change, and ifup/down when appropriate.

    Change-Id: Ib6b2c167c1718710342fdf61c40fa3fe875f2293
    Closes-Bug: #1551256

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: liberty
Review: https://review.openstack.org/289904

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/289905

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289904
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=56a4b416150ffbcf3d0ff7c55fabd2a55a20ef8f
Submitter: Jenkins
Branch: liberty

commit 56a4b416150ffbcf3d0ff7c55fabd2a55a20ef8f
Author: Andy McCrae <email address hidden>
Date: Mon Feb 29 13:57:25 2016 +0000

    Restart containers on network configuration change

    Changes to the network configuration need to cause a restart of the
    interface for the changes to take place.

    We can check the md5sum of the network interface config before and after
    the change, and ifup/down when appropriate.

    Cherry-pick of https://review.openstack.org/#/c/286078/

    Change-Id: Ib6b2c167c1718710342fdf61c40fa3fe875f2293
    Closes-Bug: #1551256

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289905
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=2b45722327ae28bd1e8beeec8fab1e79196c3c78
Submitter: Jenkins
Branch: kilo

commit 2b45722327ae28bd1e8beeec8fab1e79196c3c78
Author: Andy McCrae <email address hidden>
Date: Mon Feb 29 13:57:25 2016 +0000

    Restart containers on network configuration change

    Changes to the network configuration need to cause a restart of the
    interface for the changes to take place.

    We can check the md5sum of the network interface config before and after
    the change, and ifup/down when appropriate.

    Cherry-pick of https://review.openstack.org/#/c/286078/

    Change-Id: Ib6b2c167c1718710342fdf61c40fa3fe875f2293
    Closes-Bug: #1551256

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 12.0.9 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.15 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.