control node crash in BgpPath::IsReplicated

[Nischal Sheth]

#0 0x0000000000757d6d in BgpPath::IsVrfOriginated() const ()
#1 0x00000000007f594d in BgpXmppMessage::GetVirtualNetwork(BgpRoute const*) const ()
#2 0x00000000007f483b in BgpXmppMessage::AddEnetReach(BgpRoute const*, RibOutAttr const*) ()
#3 0x00000000007f4e74 in BgpXmppMessage::AddEnetRoute(BgpRoute const*, RibOutAttr const*) ()
#4 0x00000000007f39f0 in BgpXmppMessage::Start(RibOutAttr const*, BgpRoute const*) ()
#5 0x00000000007f5a17 in BgpXmppMessageBuilder::Create(BgpTable const*, RibOutAttr const*, BgpRoute const*) const ()
#6 0x0000000000724c23 in RibOutUpdates::DequeueCommon(UpdateMarker*, RouteUpdate*, RibPeerSet*) ()
#7 0x000000000072504a in RibOutUpdates::TailDequeue(int, RibPeerSet const&, RibPeerSet*) ()
#8 0x00000000007b5427 in SchedulingGroup::UpdateRibOut(RibOut*, int) ()
#9 0x00000000007b8157 in SchedulingGroup::Worker::Run() ()

This is the same as bug 1402785.
The problem was re-introduced as part of the fix for bug 1518034.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17986
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17987
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17986
Committed: http://github.org/Juniper/contrail-controller/commit/f14892aaef96f75bd1564f8e6ea9bd8ff614d43a
Submitter: Zuul
Branch: master

commit f14892aaef96f75bd1564f8e6ea9bd8ff614d43a
Author: Nischal Sheth <email address hidden>
Date: Fri Feb 26 17:58:51 2016 -0800

Fix concurrency issue in XmppMessageBuilder

Do not access BgpPath from bgp::SendTask because the path can get
deleted from db::DBTable task which could be running in parallel.
Store vrf_originated_ attribute in RibOutAttr instead of accessing
the best path to figure out if the route is local Vrf Originated.

Change-Id: If5318153f83d1032495c7e7f0c56293745cb37bc
Closes-Bug: 1551015

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17987
Committed: http://github.org/Juniper/contrail-controller/commit/c663ed20ff3af4978e32e21bc19ed9ced3dae8a1
Submitter: Zuul
Branch: R3.0

commit c663ed20ff3af4978e32e21bc19ed9ced3dae8a1
Author: Nischal Sheth <email address hidden>
Date: Fri Feb 26 17:58:51 2016 -0800

Fix concurrency issue in XmppMessageBuilder

Do not access BgpPath from bgp::SendTask because the path can get
deleted from db::DBTable task which could be running in parallel.
Store vrf_originated_ attribute in RibOutAttr instead of accessing
the best path to figure out if the route is local Vrf Originated.

Change-Id: If5318153f83d1032495c7e7f0c56293745cb37bc
Closes-Bug: 1551015