the 'ovs_use_veth' and 'veth_mtu' options should be deprecated

Bug #1550501 reported by Kevin Benton
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kevin Benton

Bug Description

These options were here to support an old kernel bug that shouldn't be present in distros that ship Newton. These will cause an MTU mismatch because the MTU value of the networks they support aren't known at the time of wiring.

Tags: deprecation
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
summary: - the 'ovs_use_veth' and 'veth_mtu' options should be dropped in Newton
+ the 'ovs_use_veth' and 'veth_mtu' options should be deprecated
Revision history for this message
Assaf Muller (amuller) wrote :

I think we can delete these options without a deprecation cycle. These options are not relevant for CentOS 6, which is the oldest CentOS version capable of running a supported OpenStack version.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/285532

Changed in neutron:
status: New → In Progress
Revision history for this message
Miguel Angel Ajo (mangelajo) wrote :

My investigations, sadly, showed up that we may need the ovs_veth "patch ports" to provide min bandwidth guarantees, as, those patch ports are the single points collecting the traffic that goes in/out to a network.

ovs patch ports are not linux kernel primitives, and because of that, we cannot attach queues to them, and do QoS vodoo.

see [1] , [2], and [3]

[1] https://github.com/mangelajo/ovs-experiments/blob/master/qos/qos_complex_traffic_shapping.sh#L1
[2] https://github.com/mangelajo/ovs-experiments/blob/master/qos/qos_complex_traffic_shapping.sh#L55
[3] https://github.com/mangelajo/ovs-experiments/blob/master/qos/qos_complex_traffic_shapping.sh#L276

So, please let's keep them until I get to this, may be I can look into alternatives. Somebody told me about IMQ's but that's not merged in mainstream linux kernel, and I believe there was something similar in-kernel, but I haven't been able to find it yet.

Changed in neutron:
status: In Progress → Opinion
Changed in neutron:
status: Opinion → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/285532
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=850b4c025fa5652bfa474c78e7775d74fdb93df6
Submitter: Jenkins
Branch: master

commit 850b4c025fa5652bfa474c78e7775d74fdb93df6
Author: Kevin Benton <email address hidden>
Date: Wed Feb 24 11:28:28 2016 -0800

    Deprecate 'ovs_use_veth' and 'veth_mtu' options

    These were added to support an old kernel bug with
    patch ports in OVS. This should no longer be an issue
    with distros new enough ship Ocata.

    Closes-Bug: #1550501
    Change-Id: I8cd3d74f4d7dbe57fbff180d344f21534d590ce1

Changed in neutron:
status: In Progress → Fix Released
tags: added: deprecation
Changed in neutron:
importance: Undecided → Low
Revision history for this message
sean mooney (sean-k-mooney) wrote :

as the change was reverted this bug should be reopened.
https://review.openstack.org/#/c/306807/

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/neutron 9.0.0.0b1

This issue was fixed in the openstack/neutron 9.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Bence Romsics (<email address hidden>) on branch: master
Review: https://review.openstack.org/323310

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.