LVM driver executes "vgs" with sudo instead of rootwrap

[Ben Swartzlander]

2016-02-24 05:21:24.887 15466 DEBUG oslo_service.periodic_task [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Running periodic task ShareManager._publish_service_capabilities run_periodic_tasks /usr/local/lib/python2.7/dist-packages/oslo_service/periodic_task.py:215
2016-02-24 05:21:24.887 15466 DEBUG manila.manager [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Notifying Schedulers of capabilities ... _publish_service_capabilities /opt/stack/new/manila/manila/manager.py:142
2016-02-24 05:21:24.888 15466 DEBUG oslo_messaging._drivers.amqpdriver [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] CAST unique_id: 8e2fb0de97b04ab89708c8540e114776 FANOUT topic 'manila-scheduler' _send /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/amqpdriver.py:438
2016-02-24 05:21:24.890 15466 DEBUG oslo_service.periodic_task [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Running periodic task ShareManager._report_driver_status run_periodic_tasks /usr/local/lib/python2.7/dist-packages/oslo_service/periodic_task.py:215
2016-02-24 05:21:24.891 15466 INFO manila.share.manager [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Updating share status
2016-02-24 05:21:24.891 15466 DEBUG oslo_concurrency.processutils [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Running cmd (subprocess): sudo vgs lvm-shares --rows --units g execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:326
2016-02-24 05:21:24.905 15466 DEBUG oslo_concurrency.processutils [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] CMD "sudo vgs lvm-shares --rows --units g" returned: 1 in 0.014s execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:356
2016-02-24 05:21:24.906 15466 DEBUG oslo_concurrency.processutils [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] u'sudo vgs lvm-shares --rows --units g' failed. Not Retrying. execute /usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py:404
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task [req-6e5380c5-4314-40ff-9827-66b7337eb208 - - - - -] Error during ShareManager._report_driver_status
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task Traceback (most recent call last):
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/usr/local/lib/python2.7/dist-packages/oslo_service/periodic_task.py", line 220, in run_periodic_tasks
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task task(self, context)
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/utils.py", line 614, in wrapper
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task return func(self, *args, **kwargs)
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/share/manager.py", line 1526, in _report_driver_status
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task share_stats = self.driver.get_share_stats(refresh=True)
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/share/driver.py", line 690, in get_share_stats
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task self._update_share_stats()
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/share/drivers/lvm.py", line 188, in _update_share_stats
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task 'pools': self.get_share_server_pools()
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/share/drivers/lvm.py", line 195, in get_share_server_pools
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task '--rows', '--units', 'g')
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/opt/stack/new/manila/manila/utils.py", line 63, in execute
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task return processutils.execute(*cmd, **kwargs)
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/processutils.py", line 371, in execute
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task cmd=sanitized_cmd)
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task ProcessExecutionError: Unexpected error while running command.
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task Command: sudo vgs lvm-shares --rows --units g
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task Exit code: 1
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task Stdout: u''
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task Stderr: u'sudo: no tty present and no askpass program specified\n'
2016-02-24 05:21:24.906 15466 ERROR oslo_service.periodic_task

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/285107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285107
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=29020b47f775cf62cc549d2b3f53691dd4cc1f24
Submitter: Jenkins
Branch: master

commit 29020b47f775cf62cc549d2b3f53691dd4cc1f24
Author: Ben Swartzlander <email address hidden>
Date: Thu Feb 25 23:57:21 2016 -0500

    Change sudo to run_as_root in LVM driver

    The LVM driver was using sudo for one command instead
    of proper rootwrap usage. This caused failures when the
    user running manila-share didn't have passwordless sudo
    access.

    Depends-On: Ib1896997f2e7a505b5bf8ec0c9e5ee35942f79a6
    Change-Id: I48ea946c2b8de2ebf0e067ef4829b81cabd1464f
    Closes-Bug: 1550121

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.