fwts: memory leak when reading MSRs when checking if check if CPU has C1E bit
Bug #1549723 reported by
Colin Ian King
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Firmware Test Suite |
Fix Released
|
Low
|
Colin Ian King |
Bug Description
Resource leak on failed MSR read. Minor issue, should be fixed.
226 if (fwts_cpu_
CID 1351543 (#2 of 2): Resource leak (RESOURCE_LEAK)11. leaked_storage: Variable cpu going out of scope leaks the storage it points to.
227 return FWTS_BOOL_ERROR;
228 if (!(val & 2)) {
229 fwts_cpu_
230 return FWTS_FALSE;
affects: | plainbox-provider-checkbox → fwts |
Changed in fwts: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in fwts: | |
milestone: | none → 16.03.00 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I also noticed that we need to fix the case when family 0x0f models < rev F do not have C1E, the code was erroneously returning true instead of false.