provider_net does not need physical network required

Bug #1549702 reported by jz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
jz

Bug Description

physical_network should not be a required option for the user to provide when creating provider_net

jz (danielradcliffe2004)
Changed in heat:
assignee: nobody → jz (danielradcliffe2004)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/285211

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
Rabi Mishra (rabi) wrote :

Can you please elaborate on the requirement? We support provider:network_type of type flat/vlan with ProviderNet resource and AFAIK, both of them require physical_network.

Revision history for this message
jz (danielradcliffe2004) wrote :

In the case of the NSX|V plugin, we do not require the user to provide the physical network.
but if we use current code, the physical_network is a must property.

Changed in heat:
importance: Undecided → Medium
milestone: none → newton-1
Revision history for this message
Rabi Mishra (rabi) wrote :

I thinks it's not required only for NSX plugin. We can make it optional at cost of it failing in all other cases(if not specified).

Revision history for this message
Yang Yu (yuyangbj) wrote :

@Rabi,

We do not need the physical_network because we have provided a default value for it, user can input this property, but we will use the default value if they did not input it. I think it is more convenient to operate for customers.

Revision history for this message
Rabi Mishra (rabi) wrote :

What I understand from NSX-v docs,

--provider:physical_network is the managed object reference of the distributed virtual switch the distributed port group should be created on.

If the argument “--provider:physical_network” is omitted, the distributed port group will be created on the distributed virtual switch that is specified by the dvs_id configuration parameter in the nsx.ini.

You can easily use as a parameter with a default value as the dvs_id in nsx.ini

IMO, we should not change the resource plugin to cater to a specific neutron plugin(nsxv). However, I'll not block it.

Changed in heat:
assignee: jz (danielradcliffe2004) → Oleksii Chuprykov (ochuprykov)
Changed in heat:
assignee: Oleksii Chuprykov (ochuprykov) → nobody
assignee: nobody → jz (danielradcliffe2004)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/285211
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5e7d1e03c2b56b3c877949ca12165f33903847b7
Submitter: Jenkins
Branch: master

commit 5e7d1e03c2b56b3c877949ca12165f33903847b7
Author: danny <email address hidden>
Date: Fri Nov 27 11:44:26 2015 +0800

    Make physical_network property optional

    physical_network property should not be
    required when creating provider_network

    Change-Id: I04510d8b3ac11e66ba85b9fdc36f98fbec198de6
    Closes-Bug: #1549702

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b1

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.