provider_net does not need physical network required

[jz]

physical_network should not be a required option for the user to provide when creating provider_net

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/285211

[Rabi Mishra (rabi)]

Can you please elaborate on the requirement? We support provider:network_type of type flat/vlan with ProviderNet resource and AFAIK, both of them require physical_network.

[jz (danielradcliffe2004)]

In the case of the NSX|V plugin, we do not require the user to provide the physical network.
but if we use current code, the physical_network is a must property.

[Rabi Mishra (rabi)]

I thinks it's not required only for NSX plugin. We can make it optional at cost of it failing in all other cases(if not specified).

[Yang Yu (yuyangbj)]

@Rabi,

We do not need the physical_network because we have provided a default value for it, user can input this property, but we will use the default value if they did not input it. I think it is more convenient to operate for customers.

[Rabi Mishra (rabi)]

What I understand from NSX-v docs,

--provider:physical_network is the managed object reference of the distributed virtual switch the distributed port group should be created on.

If the argument “--provider:physical_network” is omitted, the distributed port group will be created on the distributed virtual switch that is specified by the dvs_id configuration parameter in the nsx.ini.

You can easily use as a parameter with a default value as the dvs_id in nsx.ini

IMO, we should not change the resource plugin to cater to a specific neutron plugin(nsxv). However, I'll not block it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285211
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5e7d1e03c2b56b3c877949ca12165f33903847b7
Submitter: Jenkins
Branch: master

commit 5e7d1e03c2b56b3c877949ca12165f33903847b7
Author: danny <email address hidden>
Date: Fri Nov 27 11:44:26 2015 +0800

    Make physical_network property optional

    physical_network property should not be
    required when creating provider_network

    Change-Id: I04510d8b3ac11e66ba85b9fdc36f98fbec198de6
    Closes-Bug: #1549702

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.