detach of AAP on service instance doesnt work

[Senthilnathan Murugappan]

Detach of aap from the service instance interface properties would throw the below exception

 /usr/lib/python2.7/dist-packages/svc_monitor/port_tuple.py in set_secondary_ip_tracking_ip(self=<svc_monitor.port_tuple.PortTupleAgent object>, vmi=<svc_monitor.config_db.VirtualMachineInterfaceSM object>)
  117 if not iip or not iip.instance_ip_secondary:
  118 continue
  119 if iip.secondary_tracking_ip == vmi.aaps[0]['ip']:
  120 continue
  121 iip_obj = self._vnc_lib.instance_ip_read(id=iip.uuid)
iip = <svc_monitor.config_db.InstanceIpSM object>
iip.secondary_tracking_ip = {u'ip_prefix': u'27.210.176.100', u'ip_prefix_len': 32}
vmi = <svc_monitor.config_db.VirtualMachineInterfaceSM object>
vmi.aaps = []
<type 'exceptions.IndexError'>: list index out of range __class__ = <type 'exceptions.IndexError'>
    __delattr__ = <method-wrapper '__delattr__' of exceptions.IndexError object>
    __dict__ = {} __doc__ = 'Sequence index out of range.'
    __format__ = <built-in method __format__ of exceptions.IndexError object>
    __getattribute__ = <method-wrapper '__getattribute__' of exceptions.IndexError object>
    __getitem__ = <method-wrapper '__getitem__' of exceptions.IndexError object>
    __getslice__ = <method-wrapper '__getslice__' of exceptions.IndexError object>
    __hash__ = <method-wrapper '__hash__' of exceptions.IndexError object>
    __init__ = <method-wrapper '__init__' of exceptions.IndexError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of exceptions.IndexError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of exceptions.IndexError object>
    __repr__ = <method-wrapper '__repr__' of exceptions.IndexError object> __setattr__ = <method-wrapper '__setattr__' of exceptions.IndexError object>
    __setstate__ = <built-in method __setstate__ of exceptions.IndexError object>
    __sizeof__ = <built-in method __sizeof__ of exceptions.IndexError object>
    __str__ = <method-wrapper '__str__' of exceptions.IndexError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __unicode__ = <built-in method __unicode__ of exceptions.IndexError object>
    args = ('list index out of range',)
    message = 'list index out of range'

The above is a description of an error in a Python program. Here is
the original traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/svc_monitor/rabbit.py", line 39, in _vnc_subscribe_callback
    self._vnc_subscribe_actions(oper_info)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/rabbit.py", line 108, in _vnc_subscribe_actions
    res_obj.evaluate()
  File "/usr/lib/python2.7/dist-packages/svc_monitor/config_db.py", line 587, in evaluate
    self._manager.port_tuple_agent.update_port_tuple(pt_id=pt_id)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/port_tuple.py", line 261, in update_port_tuple
    self.set_port_allowed_address_pairs(port, vmi, vmi_obj)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/port_tuple.py", line 137, in set_port_allowed_address_pairs
    self.set_secondary_ip_tracking_ip(vmi)
  File "/usr/lib/python2.7/dist-packages/svc_monitor/port_tuple.py", line 119, in set_secondary_ip_tracking_ip
    if iip.secondary_tracking_ip == vmi.aaps[0]['ip']:
IndexError: list index out of range

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17777
Submitter: Rudra Rugge (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17571
Submitter: Rudra Rugge (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17571
Committed: http://github.org/Juniper/contrail-controller/commit/04efc9db3bf7685c920a46af87e1824bc3952999
Submitter: Zuul
Branch: R3.0

commit 04efc9db3bf7685c920a46af87e1824bc3952999
Author: Rudra Rugge <email address hidden>
Date: Mon Feb 22 11:44:20 2016 -0800

Interface route table deleted for service

Interface route table deleted instantly by service monitor as the
virtual machine interface count is zero on create. The handling should
be done as part of VMI evaluate.
Also add handling of multiple health checks attached to the same SI port.

Change-Id: Icd2fb0e891a09c632c3bb132fd70f9ef9709d5ba
Closes-Bug: #1544472
Closes-Bug: #1548689
Closes-Bug: #1548641
Closes-Bug: #1549551

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17777
Committed: http://github.org/Juniper/contrail-controller/commit/84e6526e78f4f6a50fcc8cb11d33cc8ffd2d9f19
Submitter: Zuul
Branch: master

commit 84e6526e78f4f6a50fcc8cb11d33cc8ffd2d9f19
Author: Rudra Rugge <email address hidden>
Date: Wed Feb 24 17:06:57 2016 -0800

Delete of allowed address pair

Delete of allowed address pair was not working.

Change-Id: I7674994190581a2dc8db69360e079217f1deb9fd
Closes-Bug: #1549551