delete image action enabled when not allowed

Bug #1549544 reported by Tyr Johanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Marek Lyčka

Bug Description

On the ngimages panel, select a image that you do not have permission to delete (owned by another project). The delete image action button is enabled, even though the action is immediately blocked.

Expected behavior is that delete image action button is only enabled if the action's allowed method returns success for all selected images.

Changed in horizon:
assignee: nobody → Marcellin Fom Tchassem (mf6510)
Changed in horizon:
assignee: Marcellin Fom Tchassem (mf6510) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

The policy needs to be considered.

Changed in horizon:
importance: Undecided → Medium
status: New → Triaged
milestone: none → queens-2
Ying Zuo (yingzuo)
Changed in horizon:
milestone: queens-2 → queens-3
Ola Khalifa (olakhalifa)
Changed in horizon:
assignee: nobody → Ola Khalifa (olakhalifa)
Ola Khalifa (olakhalifa)
Changed in horizon:
status: Triaged → In Progress
Ola Khalifa (olakhalifa)
Changed in horizon:
status: In Progress → Confirmed
assignee: Ola Khalifa (olakhalifa) → nobody
Ying Zuo (yingzuo)
Changed in horizon:
milestone: queens-3 → next
Changed in horizon:
assignee: nobody → Marek Lyčka (mareklycka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/584750

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/584750
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/584750
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=71cac4a145d6726703d76ce66e1787df80c3f3cf
Submitter: Zuul
Branch: master

commit 71cac4a145d6726703d76ce66e1787df80c3f3cf
Author: mareklycka <email address hidden>
Date: Mon Jul 23 09:45:55 2018 +0200

    Replaces the delete button with a disabling version

    Replaces the default delete button template for the images batch delete
    action with a custom one. This template contains a new component, which
    changes the disabled/enabled state of the underlying action based on the
    selected images allowed value as specified by the delete-image service
    used to evaluate the allowed value for individual rows/images and their
    respective delete actions.

    Closes-Bug: 1549544

    Change-Id: Idd5f59e32268cf4ceefe3639c607fb6c3520e538

Changed in horizon:
status: In Progress → Fix Released
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: next → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 15.0.0.0b2

This issue was fixed in the openstack/horizon 15.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.