Service Instance scaling breaks the static route community logic

[Ato]

Thanks to Amit Surana for debugging.

Static routes associated to Service Instances now have an option to set a community like no-reoriginate or no-export. The desired effect is observed in Service Instances cloned from a v1 template that does not have the scaling option checked.

On the other hand, if I try the same on a v1 Service Instance with scale-out (two instances), the community values that I set in the GUI is not causing any effect at all. For example, no-reoriginate does not prevent the route from being reoriginated; and no-export is not set in the route, as I can check in a MX.

I did not try on v2 Service Instances since the GUI is not ready yet.

[Nischal Sheth (nsheth)]

Note that both service instances are on the same agent in this case.
When we checked the agent route table we saw that the 2 LocaVmPort
paths have the configured community values. However, the Ecmp
path created by agent doesn't have any communities.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17791
Submitter: Prakash Bailkeri (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17792
Submitter: Prakash Bailkeri (<email address hidden>)

[Prakash Bailkeri (prakashmb)]

Update of path attribute of ECMP path is not handled when individual member path is update. Same is issue is seen with security group id update also.

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17791
Committed: http://github.org/Juniper/contrail-controller/commit/4252716186cab1e3afacb13f89def9428a64a8f7
Submitter: Zuul
Branch: master

commit 4252716186cab1e3afacb13f89def9428a64a8f7
Author: Prakash Bailkeri <email address hidden>
Date: Thu Feb 25 12:04:08 2016 +0530

Ecmp path should publish community

In case of service scaling with service VMs launched in same compute node, agent
publishes ecmp path. This path should contain the community set to individual VM
path. Logic was missing to copy the community attribute.

Fix the AllocateEcmpPath & ModifyEcmpPath to copy the individual path's community

TODO: This only fixes the case of allocation of ecmp path.
InetUnicastRouteEntry::EcmpAddPath is missing logic to update the attributes of
ecmp path when individual path is updated

Change-Id: I0ac37689e380bacef40b16a714ed11bba3565658
Partial-Bug: 1549541

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17792
Committed: http://github.org/Juniper/contrail-controller/commit/a3130c645b8ac95f1ba08b3feeed8792b21e20fe
Submitter: Zuul
Branch: R3.0

commit a3130c645b8ac95f1ba08b3feeed8792b21e20fe
Author: Prakash Bailkeri <email address hidden>
Date: Thu Feb 25 12:04:08 2016 +0530

Ecmp path should publish community

In case of service scaling with service VMs launched in same compute node, agent
publishes ecmp path. This path should contain the community set to individual VM
path. Logic was missing to copy the community attribute.

Fix the AllocateEcmpPath & ModifyEcmpPath to copy the individual path's community

TODO: This only fixes the case of allocation of ecmp path.
InetUnicastRouteEntry::EcmpAddPath is missing logic to update the attributes of
ecmp path when individual path is updated

Change-Id: I0ac37689e380bacef40b16a714ed11bba3565658
Partial-Bug: 1549541
(cherry picked from commit 4252716186cab1e3afacb13f89def9428a64a8f7)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17904
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17904
Committed: http://github.org/Juniper/contrail-controller/commit/eb156cc70223fc26997bf5566b00c9ba537ea771
Submitter: Zuul
Branch: R3.0

commit eb156cc70223fc26997bf5566b00c9ba537ea771
Author: Naveen N <email address hidden>
Date: Fri Feb 26 16:14:59 2016 +0530

* Copy SG and community id to ecmp path from local path
If SG, community or tunnel map changes for a path copy that
updated list to ecmp path.
Test case for same.
Closes-bug:#1549541

Change-Id: If6db411fa4f977fa82741b5eaad1f2b926c60684

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17994
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17994
Submitter: Praveen K V (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17994
Committed: http://github.org/Juniper/contrail-controller/commit/47b533618dd05f54d8e168195edc917a1bc4530a
Submitter: Zuul
Branch: master

commit 47b533618dd05f54d8e168195edc917a1bc4530a
Author: Naveen N <email address hidden>
Date: Fri Feb 26 16:14:59 2016 +0530

* Copy SG and community id to ecmp path from local path
If SG, community or tunnel map changes for a path copy that
updated list to ecmp path.
Test case for same.

(cherry picked from commit 5e5dae858cc944cd7b4247b9d18d34d27bc30f19)
Closes-bug:#1549541
Change-Id: If6db411fa4f977fa82741b5eaad1f2b926c60684