NetApp cDOT update_access breaks if flexvol already deleted

[Clinton Knight]

A negative internal Tempest test somehow didn't catch a problem with the recent update_access patch. If a flexvol is deleted on cDOT without Manila's knowledge, deleting the corresponding Manila share should still succeed. The core update_access changes call update_access during a share delete workflow to remove all the existing rules, and that path in the cDOT driver needs to be hardened against the cases where either share or share server no longer exist.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284877

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284877
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a5c0e9574fe6030ed48488740ef2dea4288c866d
Submitter: Jenkins
Branch: master

commit a5c0e9574fe6030ed48488740ef2dea4288c866d
Author: Clinton Knight <email address hidden>
Date: Wed Feb 24 17:59:36 2016 -0500

    Fix NetApp cDOT driver update_access negative test

    A negative internal Tempest test somehow didn't catch a problem
    with the recent update_access patch. If a flexvol is deleted on
    cDOT without Manila's knowledge, deleting the corresponding Manila
    share should still succeed. The core update_access changes call
    update_access during a share delete workflow to remove all the
    existing rules, and that path in the cDOT driver needs to be
    hardened against the cases where either share or share server
    no longer exist. Also, fix a mis-named lock object in the same
    code path.

    Change-Id: Ibb88c64ddd899c09cd148f398e21ac613be9f15b
    Closes-Bug: #1549518

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/manila 2.0.0.0b3 development milestone.