Systemd init script does not pass --pnor

[Jeremy Kerr]

We have a --pnor option that almost all opal-prd invocations will need. In the debian packaging, we have an /etc/defaults file that controls this:

[jk@pudge skiboot-5.1.1]$ grep PNOR debian/opal-prd.default
PNOR_DEVICE=/dev/mtd0

This is consumed by the sysv init script for opal-prd:

if [ "$PNOR_DEVICE" ]
then
 PNOR_OPTS="--pnor $PNOR_DEVICE"
fi

However, the systemd init script has no way of handing this:

[Service]
StandardInput=socket
ExecStart=/usr/sbin/opal-prd

So it ends up starting opal-prd without --pnor, which means the diagnostics daemon has no access to flash.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Vipin K Parashar (vipin-g)]

opal-prd.service file changes should be as below:

[Service]
StandardInput=socket
ExecStart=/usr/sbin/opal-prd --pnor /dev/mtd0

[Jeremy Kerr (jk-ozlabs)]

Or even better, (somehow) use the value from /etc/default/opal-prd.

[Jeremy Kerr (jk-ozlabs)]

Any updates here?
=

[Frédéric Bonnard (frediz)]

The feature is actually fixed but it's hardcoded in the service file.
When I'll upload a new version, I'll use /etc/default/opal-prd as Jeremy suggested.

[Frédéric Bonnard (frediz)]

This is fixed in Debian Unstable but due to the freeze in Ubuntu, it was not synced to Zesty.

[Adam Conrad (adconrad)]

This was fixed in zesty and artful.