Missing check for cluster partition

[Peter Sabaini]

The rabbitmq-server charm has a number of nrpe checks included, which is nice. However, it's missing a check that would be of great benefit -- checking for a partitioned cluster.

This could probably be simply done by installing a nrpe check that runs rabbitmqctl cluster_status and matches on something like "\{partitions,\[(.*?)\]\}"

[Edward Hope-Morley (hopem)]

could also use the update-status hook to report on detected partition

[James Hebden (ec0)]

Check added to charm here -

https://review.openstack.org/#/c/519594/

I like the idea of updating charm status, too, that would be a trivial reuse of the NRPE check. Potentially, used to kick off repair activities automatically.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/519594
Committed: https://git.openstack.org/cgit/openstack/charm-rabbitmq-server/commit/?id=c0b936c7392c554bd3b72cc669484ab0b8960b8d
Submitter: Zuul
Branch: master

commit c0b936c7392c554bd3b72cc669484ab0b8960b8d
Author: James Hebden <email address hidden>
Date: Tue Nov 14 10:34:26 2017 +0100

    Add Nagios check for cluster partitions

    This commit introduces the check_rabbitmq_cluster.py Nagios check, which
    uses the HTTP management API to check for the presence of cluster
    partitions. The check will only be installed if the management_plugin
    charm configuration is set to True, enabling the HTTP API plugin.

    The previous request to use administrator privileges to monitor cluster
    health is no longer required. The create_user and user_exists logic has
    been reworked to accomodate different tags, and the monitoring tag,
    which is respected by the HTTP management API used to monitor cluster
    health, has been used instead of the administrator privilege.

    Also cleans up usage of os.getenv('CHARM_DIR') in several places in the
    file hooks/rabbitmq_server_relations.py

    Change-Id: Ib7eb1afe258931cc917c151a2b6d72dc56d30c95
    Closes-Bug: #1548679

[OpenStack Infra (hudson-openstack)]

Change abandoned by Frode Nordahl (<email address hidden>) on branch: master
Review: https://review.openstack.org/538319
Reason: Marking this review as abandoned due to lack of activity in the past 6 months.
Feel free to restore it again if you want to pick up and continue the work.