[library] broken network config (bridge_ports)

[Aleksey Chuprin]

Fuel 7.0 + MU2

Network scheme:

{"transformations"=>
  [{"action"=>"add-br", "name"=>"br-fw-admin"},
   {"action"=>"add-br", "name"=>"br-mgmt"},
   {"action"=>"add-br", "name"=>"br-ex"},
   {"action"=>"add-bond",
    "bridge"=>"br-fw-admin",
    "bond_properties"=>{"mode"=>"active-backup"},
    "interfaces"=>["eth4", "eth6"],
    "name"=>"bond0"},
   {"action"=>"add-bond",
    "bridge"=>"br-ex",
    "bond_properties"=>{"mode"=>"active-backup"},
    "interfaces"=>["eth1", "eth3"],
    "name"=>"bond1"},
   {"action"=>"add-port", "bridge"=>"br-mgmt", "name"=>"bond1.3002"},
   {"action"=>"add-br", "name"=>"br-prv", "provider"=>"ovs"},
   {"action"=>"add-patch",
    "bridges"=>["br-prv", "br-ex"],
    "mtu"=>65000,
    "provider"=>"ovs"},
   {"action"=>"add-br", "name"=>"br-floating", "provider"=>"ovs"},
   {"action"=>"add-patch",
    "bridges"=>["br-floating", "br-ex"],
    "mtu"=>65000,
    "provider"=>"ovs"},
   {"action"=>"add-br", "name"=>"br-storage"},
   {"action"=>"add-bond",
    "bond_properties"=>{"mode"=>"active-backup"},
    "interfaces"=>["eth0", "eth2"],
    "name"=>"bond2"},
   {"action"=>"add-port", "bridge"=>"br-storage", "name"=>"bond2.3000"},
   {"action"=>"add-br", "name"=>"br-storage1"},
   {"action"=>"add-port", "bridge"=>"br-storage1", "name"=>"bond2.3001"}],
 "roles"=>
  {"murano/api"=>"br-mgmt",
   "keystone/api"=>"br-mgmt",
   "neutron/api"=>"br-mgmt",
   "mgmt/database"=>"br-mgmt",
   "sahara/api"=>"br-mgmt",
   "fake"=>nil,
   "ceilometer/api"=>"br-mgmt",
   "ex"=>"br-ex",
   "ceph/public"=>"br-mgmt",
   "mgmt/messaging"=>"br-mgmt",
   "management"=>"br-mgmt",
   "swift/api"=>"br-mgmt",
   "mgmt/api"=>"br-mgmt",
   "storage"=>"br-storage",
   "mgmt/corosync"=>"br-mgmt",
   "cinder/api"=>"br-mgmt",
   "public/vip"=>"br-ex",
   "swift/replication"=>"br-storage",
   "ceph/radosgw"=>"br-ex",
   "neutron/mesh"=>nil,
   "admin/pxe"=>"br-fw-admin",
   "mongo/db"=>"br-mgmt",
   "neutron/private"=>"br-prv",
   "neutron/floating"=>"br-floating",
   "fw-admin"=>"br-fw-admin",
   "glance/api"=>"br-mgmt",
   "mgmt/vip"=>"br-mgmt",
   "heat/api"=>"br-mgmt",
   "nova/api"=>"br-mgmt",
   "horizon"=>"br-mgmt",
   "nova/migration"=>"br-mgmt",
   "mgmt/memcache"=>"br-mgmt",
   "cinder/iscsi"=>"br-storage",
   "ceph/replication"=>"br-storage"},
 "interfaces"=>
  {"eth7"=>{"vendor_specific"=>{"driver"=>"tg3", "bus_info"=>"0000:02:00.3"}},
   "eth6"=>{"vendor_specific"=>{"driver"=>"tg3", "bus_info"=>"0000:02:00.2"}},
   "eth5"=>{"vendor_specific"=>{"driver"=>"tg3", "bus_info"=>"0000:02:00.1"}},
   "eth4"=>{"vendor_specific"=>{"driver"=>"tg3", "bus_info"=>"0000:02:00.0"}},
   "eth3"=>
    {"vendor_specific"=>{"driver"=>"ixgbe", "bus_info"=>"0000:05:00.1"}},
   "eth2"=>
    {"vendor_specific"=>{"driver"=>"ixgbe", "bus_info"=>"0000:05:00.0"}},
   "eth1"=>
    {"vendor_specific"=>{"driver"=>"ixgbe", "bus_info"=>"0000:04:00.1"}},
   "eth0"=>
    {"vendor_specific"=>{"driver"=>"ixgbe", "bus_info"=>"0000:04:00.0"}}},
 "version"=>"1.1",
 "provider"=>"lnx",
 "endpoints"=>
  {"br-prv"=>{"IP"=>"none"},
   "br-fw-admin"=>{"IP"=>["ip/24"]},
   "br-storage1"=>{"IP"=>["ip/23"]},
   "br-floating"=>{"IP"=>"none"},
   "br-storage"=>{"IP"=>["ip/23"]},
   "br-mgmt"=>{"IP"=>["ip/24"]},
   "br-ex"=>{"IP"=>["ip/24"], "gateway"=>"ip"}}}

Result of netconfig.pp:

cat /etc/network/interfaces.d/ifcfg-br-ex
auto br-ex
iface br-ex inet static
bridge_ports bond1
address ip/24
gateway ip

Expected result:

cat /etc/network/interfaces.d/ifcfg-br-ex
auto br-ex
iface br-ex inet static
bridge_ports bond1 p_408821a5-0 p_ff798dba-0
address ip/24
gateway ip

As we can see if we use Fuel 7.0 + MU2 bridge_ports param doesn't include patch interfaces . As result after reboot we get node with broken network.

!!!!Fuel 7.0 + MU1 works fine.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/284260

[Vladimir Kuklin (vkuklin)]

This bug was not triaged against 8.0 and 9.0 milestones. Is it invalid for them?

[Vitaly Sedelnik (vsedelnik)]

This bug is reported against 7.0-mu-2 and caused by https://review.openstack.org/#/c/267055/ which is a part of 8.0 changes for l23network. The appropriate code for 8.0 is contained here - https://review.openstack.org/#/c/246296/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284260
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3e0383124905068c6fd108417a5df91409bec942
Submitter: Jenkins
Branch: stable/7.0

commit 3e0383124905068c6fd108417a5df91409bec942
Author: slava <email address hidden>
Date: Wed Feb 24 19:55:02 2016 +0300

    Fix bridge_ports option for linux bridges

    Currently, new interface type(vport) was introduced,
    but, interface of this type can not be connected to
    linux bridge in stored configuration due to condition
    checking its type.

    Change-Id: I6509e366f00b1276738566919a6c1845ea4eee11
    Closes-bug: #1548248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285115
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=26ef9bc7fc2111b2266a7de815dc9ade1df45a92
Submitter: Jenkins
Branch: stable/7.0

commit 26ef9bc7fc2111b2266a7de815dc9ade1df45a92
Author: Artem Panchenko <email address hidden>
Date: Fri Feb 19 00:43:30 2016 +0200

    Check cloud health after reboot in bonding tests

    Add execution of network verification and OSTF in
    order to check that all cloud services are started
    and work properly after cluster reboot

    Change-Id: I7e1868efc7d2a34e1cb1486f6fd678e20c8850b4
    Related-bug: #1548248
    (cherry picked from commit f75c8e3174d394060588f8f3866c2f4cab830624)

[Atsuko Ito (yottatsa)]

Test scenario

1. Create VLAN-segmentated environment
2. Create bonded interface
3. Put Public untagged on bonded interface
4. Put Private on bonded interface
5. Deploy environment
6. Check that bridge_ports in file /etc/network/interfaces.d/ifcfg-br-ex contains bond and patches.

[Ekaterina Shutova (eshutova)]

Verified on MOS 7.0 + mu3 updates.

Test scenario is described above.
Result:
root@node-4:~# cat /etc/network/interfaces.d/ifcfg-br-ex
auto br-ex
iface br-ex inet static
bridge_ports bond0 p_408821a5-0 p_ff798dba-0
address 10.109.6.4/24
gateway 10.109.6.1
post-up sleep 15