Separate deployment task can be started for offline nodes

[Julia Aranovich]

Reproduced on fake UI.

Separate deployment task can be started for offline node(s) (PUT /api/clusters/x/deploy with empty data) without any errors and these offline nodes will have 'ready' status after the deployment.

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Dmitry Guryanov (dguryanov)]

I've tried provision for offline node. It's failed after some time with mcollective error. Node is in discover state (UI shows 'pending addition').

If you run deploy for offline node, it also fails and node is in error state.

So the only thing we can improve is to fail early with an error like 'Can't start provision, node(s) <ids> are offline'.

[Dmitry Guryanov (dguryanov)]

Everything works as expected, so I've closed this bug as invalid.

[Julia Aranovich (jkirnosova)]

Separate provisioning and deployment tasks are considered as advanced actions and offline nodes do not block them.