[SRU] please remove libqt5webkit dependency
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
signon-ui (Ubuntu) |
Fix Released
|
Medium
|
Alberto Mardegan | ||
Xenial |
Won't Fix
|
Medium
|
Alberto Mardegan | ||
Yakkety |
Fix Released
|
Medium
|
Alberto Mardegan |
Bug Description
This is an SRU request, based on the process documented at https:/
[Impact]
* When declaring online accounts for use by Ubuntu, the system uses a webview to authenticate to online services like Facebook or Google.
* On X11 desktops, that webview currently uses an old qt5webkit component that is now unmaintained
* Backporting this fix will simplify the maintenance work, by removing the need for that old component, and will improve the coherence of the system by using a supported Oxide webview
[Test Case]
To verify the change:
* Go to system settings > Online Accounts
* Add account of type Google, Facebook or Twitter (which uses webview for authentication)
* Verify that a webview opens to log onto the online service
* Verify that the account is listed in the account list at the end of this process
* Verify that the related apps and services can use the online account as before (ie Shotwell photo uploads, Photos scope, etc.)
[Regression Potential]
* On architectures not supported by Oxide, namely ppc64el and s390x, the change will trigger a runtime error when trying to use that part of signon-ui.
* The problem affects users of Ubuntu desktop systems based on X11. The change is already in effect on Unity8/Mir devices for a few months.
[Other Info]
* signon-ui-x11(http://
* See also: https:/
Related branches
- Online Accounts: Pending requested
-
Diff: 123 lines (+28/-16)6 files modifiedsrc/qml/DefaultPage.qml (+1/-1)
src/qml/MainWindow.qml (+2/-2)
src/qml/WebView.qml (+21/-9)
src/qquick-dialog.cpp (+1/-1)
src/request.cpp (+1/-3)
src/ubuntu-browser-request.cpp (+2/-0)
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Online Accounts: Pending requested
-
Diff: 123 lines (+28/-16)6 files modifiedsrc/qml/DefaultPage.qml (+1/-1)
src/qml/MainWindow.qml (+2/-2)
src/qml/WebView.qml (+21/-9)
src/qquick-dialog.cpp (+1/-1)
src/request.cpp (+1/-3)
src/ubuntu-browser-request.cpp (+2/-0)
summary: |
- Build without libqt5webkit dependancy + CRITICAL: please remove libqt5webkit dependancy |
Changed in canonical-devices-system-image: | |
status: | New → Confirmed |
no longer affects: | canonical-devices-system-image |
tags: | added: xenial |
Changed in signon-ui (Ubuntu): | |
milestone: | none → ubuntu-16.04.1 |
Changed in signon-ui (Ubuntu Xenial): | |
milestone: | none → ubuntu-16.04.1 |
Changed in signon-ui (Ubuntu Yakkety): | |
milestone: | ubuntu-16.04.1 → none |
Changed in signon-ui (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Alberto Mardegan (mardy) |
Changed in signon-ui (Ubuntu Yakkety): | |
assignee: | nobody → Alberto Mardegan (mardy) |
Changed in signon-ui (Ubuntu Xenial): | |
importance: | Undecided → Medium |
description: | updated |
description: | updated |
summary: |
- CRITICAL: please remove libqt5webkit dependancy + [SRU] please remove libqt5webkit dependancy |
summary: |
- [SRU] please remove libqt5webkit dependancy + [SRU] please remove libqt5webkit dependency |
I've spent some time investigating the possibility of replacing QtWebkit with the Ubuntu.Web module (which internally uses Oxide), but the task looks far from trivial, and we should consider whether the request is worth the effort.
There are also two points to consider:
1) While indeed Oxide would be the safest bet from a security point of view, we use this webview for showing service login portals, which typically are safe to browse as they don't include third party content where malicious code could reside.
2) Oxide only works in x86-64, i386 and armhf architectures
Summing up, while I think we should be definitely moving towards the goal of not using QtWebkit1, I don't see a critical urgency of doing this for the LTS. So I'll be working on this bug as time permits, unless of course more reasons for the urgency are given.