eslint warnings should have a treshold

Bug #1547415 reported by Itxaka Serrano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Low
Itxaka Serrano

Bug Description

We should make eslint warnings to have a threshold to avoid adding more and more warnings to our javascript code.

Right now we are at 465 warning and it does not seem to decrease over time. A limit should be put in place to avoid increasing the number of warnings over time.

Itxaka Serrano (itxaka)
Changed in horizon:
assignee: nobody → Itxaka Serrano (itxakaserrano)
Changed in horizon:
status: New → In Progress
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Given that we have lintq, I don't think capping the warnings is really necessary. If we want to hide them we can use lintq; if we want to see them, we can use lint.

Changed in horizon:
status: In Progress → Opinion
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Patch here: https://review.openstack.org/#/c/282252/

I misunderstood the intent of this bug report. When current warnings > max warnings, lint will fail. I read the report as intending to simply hide the warnings when over a certain cap, thinking it was a utility. Sorry!

Changed in horizon:
status: Opinion → In Progress
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Itxaka Serrano Garcia (<email address hidden>) on branch: master
Review: https://review.openstack.org/282252
Reason: Not needed

Revision history for this message
Itxaka Serrano (itxaka) wrote :

Not needed

Changed in horizon:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.