Figure out what to do with viewport and <meta name="viewport"> on a docked device

Bug #1547145 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
High
Chris Coulson

Bug Description

Currently on mobile form factors, we enable 2 settings in Blink - viewportEnabled and viewportMetaEnabled. These are both disabled on desktop.

The former is enabled by passing --enable-viewport. The latter is enabled via content::WebPreferences::viewport_meta_enabled.

First of all, it looks like setting WebPreferences::viewport_meta_enabled implies --enable-viewport, so we can stop explicitly enabling that in Oxide.

But I'm not sure what to do with viewport meta - should we disable it on a device in desktop mode, or enable it everywhere?

Changed in oxide:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Actually, --enable-viewport is required to enable pinch-zoom, unless we pass --enable-pinch (see bug 1547138)

Changed in oxide:
milestone: none → branch-1.18
assignee: nobody → Chris Coulson (chrisccoulson)
status: Triaged → In Progress
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
Changed in oxide:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.