Signal script dist_multi_sig_mr() includes all linked signal heads

Bug #1547013 reported by Joseph Hoevet
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Open Rails
Fix Released
Medium
Carlo Santucci

Bug Description

The signal scripting dist_multi_sig_mr() function does not behave in Open Rails as it does in MSTS.

"The function takes two arguments. The first argument tells the function what type of signal you want to get the indication of. The second argument tells the function what type of signal you want to stop at. The function returns the most-restrictive
indication of all signals of the first type, until a signal of the second type is encountered. If a signal head of the first type exists on the same shape as the first second type specified, then that first type head’s indication counts. Any signal heads of the first type which are linked to a track but whose route is not available are ignored and treated as they do not exist at all."

The incorrect behavior in OR that I have seen relates to that last sentence. Any signal head that is linked to a track should be ignored if that track is not currently routed. In other words, if that linked signal's own code were to call route_set() at that moment and return False, then dist_multi_sig_mr() should ignore that signal head and pretend it does not exist. This currently is not the case.

To my knowledge this bug has been present in every version of Open Rails.

Tags: signals
Joseph Hoevet (jovet)
tags: added: signals
removed: signal
James Ross (twpol)
tags: removed: dist+multi+sig+mr dist-multi-sig-mr distant home signaling
Revision history for this message
Joseph Hoevet (jovet) wrote :

From what I can determine, this bug has been resolved in 3538.

Changed in or:
status: New → Fix Committed
James Ross (twpol)
Changed in or:
assignee: nobody → Carlo Santucci (carlosanit1)
milestone: none → 1.2
importance: Undecided → Medium
Revision history for this message
Carlo Santucci (carlosanit1) wrote :

James, 3538 has been generated by roeter and not by myself. I didn't put him as assigned person because apparently I don't have this assignment right (I tried).

Derek Morton (derek-a)
Changed in or:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.