Network Router-Interface CRUD

[Reedip]

Neutron supports router-interface-add and router-interface-delete
This support should be provided to osc while NeutronClient is migrating to OSC.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
usage: neutron router-interface-add [-h] [--request-format {json}]
                                    ROUTER INTERFACE

Add an internal network interface to a router.

positional arguments:
  ROUTER ID or name of the router.
  INTERFACE The format is "SUBNET|subnet=SUBNET|port=PORT". Either
                        a subnet or port must be specified. Both ID and name
                        are accepted as SUBNET or PORT. Note that "subnet="
                        can be omitted when specifying a subnet.

optional arguments:
  -h, --help show this help message and exit
  --request-format {json}
                        DEPRECATED! Only JSON request format is supported.
reedip@reedip-VirtualBox:/opt/stack/python-openstackclient$ neutron router-interface-delete --help
usage: neutron router-interface-delete [-h] [--request-format {json}]
                                       ROUTER INTERFACE

Remove an internal network interface from a router.

positional arguments:
  ROUTER ID or name of the router.
  INTERFACE The format is "SUBNET|subnet=SUBNET|port=PORT". Either
                        a subnet or port must be specified. Both ID and name
                        are accepted as SUBNET or PORT. Note that "subnet="
                        can be omitted when specifying a subnet.

optional arguments:
  -h, --help show this help message and exit
  --request-format {json}
                        DEPRECATED! Only JSON request format is supported.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281691

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/281694

[Richard Theis (rtheis)]

I think we should be tracking this work via a new blueprint. I would rather not have https://blueprints.launchpad.net/python-openstackclient/+spec/neutron-client grow larger and continue indefinitely. Please see my comment from Feb 11, 2016 in the blueprint.

[Reedip (reedip-banerjee-deactivatedaccount)]

@Richard: Will keep this in mind with the future patches for Migration.
However, I think we should segregate the Blueprint for future patches. As you said, it is becoming larger!

[Reedip (reedip-banerjee-deactivatedaccount)]

@Richard: I read your comment again, and I think I read it inversely the first time :D
We should ideally divide the neutron-client Blueprint into stages, with the basic operations like Network, Router , Port, Subnet, SG etc in the first phase, Router-Interface, subnet-pool ( i.e, the CLIs which extend the basic functionality of Core CLIs) in the second phase, and the advanced services ( FWaaS, VPNaaS, LBaaS ) in the third.... what do you think?

[Richard Theis (rtheis)]

@Reedip: I've opened a blueprint for this work https://blueprints.launchpad.net/python-openstackclient/+spec/neutron-client-advanced-router. After recent discussions in OSC meetings, the plan forward is to scope future blueprints to specific resources and not use bugs. Please see https://review.openstack.org/#/c/282555/ for the advanced services plan. We will maintain the current scope for the neutron-client blueprint since most of the work is complete or in progress.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289716

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/289717

[OpenStack Infra (hudson-openstack)]

Change abandoned by Reedip (<email address hidden>) on branch: master
Review: https://review.openstack.org/289717

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281691
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=2e94f2803fca3862589fe2b10c76c2ebc9e17229
Submitter: Jenkins
Branch: master

commit 2e94f2803fca3862589fe2b10c76c2ebc9e17229
Author: reedip <email address hidden>
Date: Thu Feb 18 17:12:05 2016 +0900

    Add "router add port" to osc

    This patch proposes the migration of port addition of
    Neutron's "router-interface-add" to OSC's "router add port".

    Change-Id: I3a8a76d384caa32975f8e77f50f3cf3c3be13786
    Closes-Bug: #1546849
    Depends-On: I9783bc4ccceae3d361dce52d51483ef2187920a9
    Implements: blueprint neutron-client-advanced-router

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/281694
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=8ecdc57ea680b7e20835bea69a2d18e1460d9406
Submitter: Jenkins
Branch: master

commit 8ecdc57ea680b7e20835bea69a2d18e1460d9406
Author: reedip <email address hidden>
Date: Sat Mar 19 12:04:00 2016 +0900

    Add "router remove port" to osc

    This patch proposes the migration of port
    deletion of Neutron's "router-interface-delete"
    to OSC's "router remove port".

    Change-Id: Ifceabce080aacac9f6410c809fcc097760e0c5ee
    Partial-Bug: #1546849
    Implements: blueprint neutron-client-advanced-router

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/289716
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=9e42daa577b0f15c349c2f4a79b3632ffec97720
Submitter: Jenkins
Branch: master

commit 9e42daa577b0f15c349c2f4a79b3632ffec97720
Author: reedip <email address hidden>
Date: Sun Mar 20 16:05:49 2016 +0900

    Add Subnet add/remove support to router

    The following patch adds the support for
    "router add subnet" and "router remove subnet"
    to the OSC as a part of migration of Neutron's
    CLI commands.

    Partial-Bug: #1546849
    Implements: blueprint neutron-client-advanced-router
    Change-Id: Ia3770c41026194bdb1543d4e67446f81936d44d1

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-openstackclient 2.4.0 release.